Skip to content

Commit

Permalink
dtoverlays: Fix noints mode of mcp23017
Browse files Browse the repository at this point in the history
noints mode disables 2 fragments that configure a GPIO to
be used for the interrupt line from the MCP23017, but fails
to remove the pinctrl-0 reference or pinctrl-names.
It therefore fails to load due to an invalid phandle.

Move the pinctrl-0 and pinctrl-names properties so they
also get disabled by the noints override.

https://forums.raspberrypi.com/viewtopic.php?t=370907

Signed-off-by: Dave Stevenson <[email protected]>
  • Loading branch information
6by9 authored and pelwell committed May 16, 2024
1 parent c40b423 commit 384ad7f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions arch/arm/boot/dts/overlays/mcp23017-overlay.dts
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,8 @@
target = <&mcp23017>;
mcp23017_irq: __overlay__ {
#interrupt-cells=<2>;
pinctrl-name = "default";
pinctrl-0 = <&mcp23017_pins>;
interrupt-parent = <&gpio>;
interrupts = <4 2>;
interrupt-controller;
Expand All @@ -49,8 +51,6 @@

mcp23017: mcp@20 {
compatible = "microchip,mcp23017";
pinctrl-name = "default";
pinctrl-0 = <&mcp23017_pins>;
reg = <0x20>;
gpio-controller;
#gpio-cells = <2>;
Expand Down

0 comments on commit 384ad7f

Please sign in to comment.