Skip to content

Commit

Permalink
overlays: Fix mcp23017's addr parameter
Browse files Browse the repository at this point in the history
The addr parameter of the mcp23017 overlay was broken by the addition
of the noints parameter; splitting the mcp node in two without also
modifying the second half from the addr parameter would cause the two
halves to separate. Change the implementation strategy to patch
fragment 2 (as was originally proposed). This will prevent the
overlay from being applied at runtime until the "dtoverlay" command
is improved, but the overlay already has this restriction due to
fragment 3 so this isn't a step backwards.

See: #3449

Signed-off-by: Phil Elwell <[email protected]>
  • Loading branch information
pelwell authored and popcornmix committed Feb 20, 2020
1 parent f45a52a commit 1725b06
Showing 1 changed file with 7 additions and 9 deletions.
16 changes: 7 additions & 9 deletions arch/arm/boot/dts/overlays/mcp23017-overlay.dts
Original file line number Diff line number Diff line change
Expand Up @@ -48,15 +48,13 @@
};

fragment@4 {
target = <&i2c1>;
__overlay__ {
mcp23017_irq: mcp@20 {
#interrupt-cells=<2>;
interrupt-parent = <&gpio>;
interrupts = <4 2>;
interrupt-controller;
microchip,irq-mirror;
};
target = <&mcp23017>;
mcp23017_irq: __overlay__ {
#interrupt-cells=<2>;
interrupt-parent = <&gpio>;
interrupts = <4 2>;
interrupt-controller;
microchip,irq-mirror;
};
};

Expand Down

0 comments on commit 1725b06

Please sign in to comment.