Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image_dx/deinterlace: GPU memory leak (regression) #429

Closed
julianscheel opened this issue May 18, 2015 · 7 comments
Closed

image_dx/deinterlace: GPU memory leak (regression) #429

julianscheel opened this issue May 18, 2015 · 7 comments

Comments

@julianscheel
Copy link

Commit b6e3bf1 introduces a gpu-side memory leak for me. It seems that whenever the image_fx filter (in advanced mode) is recreated one or two 621K blocks like the following are lost

$ vcdbg reloc
...
[  90] 0x1b53a020: used 621K (refcount 1 lock count 0, size   635904, d1rual) 'deinterlace'
...

The loss is persistent over the ARM side application lifecycle.

I am trying to make up a little test-snippet for this, but maybe it's obvious to you even without a snippet what went wrong?

@popcornmix
Copy link
Contributor

Don't worry about the test code for now.
The information you've provided narrows it down pretty well - I'll let you know if I can't reproduce it.

@julianscheel
Copy link
Author

Perfect, thank you

@popcornmix
Copy link
Contributor

Okay, that seemed to be straightforward - will be fixed in next firmware update

@julianscheel
Copy link
Author

Great, any ETA for the next firmware?

@popcornmix
Copy link
Contributor

There is a kernel change that wants to go out soon, so shouldn't be long. Tonight or tomorrow I expect.

popcornmix added a commit that referenced this issue May 18, 2015
See: #397

kernel: bcm2835-sdhost: Adding overclocking option
kernel: bcm2835-mmc: Adding overclocking option
See: http://forum.kodi.tv/showthread.php?tid=224025&pid=2005396#pid2005396

kernel: config: Add CONFIG_CIFS_UPCALL
See: raspberrypi/linux#968

kernel: config: Add CONFIG_FB_SSD1307=m
See: raspberrypi/linux#969

firmware: di_adv: Fix memory leak of converted buffers
See: #429

firmware: arm_display: Fix initialisation of framebuffer struct when framebuffer base is passed in

firmware: hdmi: Tweak hdmi_mai_thresh for 192kHz audio
See: https://discourse.osmc.tv/t/rp2-multichannel-flac-playback/2627/28

firmware: vcsm: Update to header from kernel side
popcornmix added a commit to Hexxeh/rpi-firmware that referenced this issue May 18, 2015
See: raspberrypi/firmware#397

kernel: bcm2835-sdhost: Adding overclocking option
kernel: bcm2835-mmc: Adding overclocking option
See: http://forum.kodi.tv/showthread.php?tid=224025&pid=2005396#pid2005396

kernel: config: Add CONFIG_CIFS_UPCALL
See: raspberrypi/linux#968

kernel: config: Add CONFIG_FB_SSD1307=m
See: raspberrypi/linux#969

firmware: di_adv: Fix memory leak of converted buffers
See: raspberrypi/firmware#429

firmware: arm_display: Fix initialisation of framebuffer struct when framebuffer base is passed in

firmware: hdmi: Tweak hdmi_mai_thresh for 192kHz audio
See: https://discourse.osmc.tv/t/rp2-multichannel-flac-playback/2627/28

firmware: vcsm: Update to header from kernel side
@popcornmix
Copy link
Contributor

Can you rpi-update and test?

@julianscheel
Copy link
Author

Looks good! Thank you :)

neuschaefer pushed a commit to neuschaefer/raspi-binary-firmware that referenced this issue Feb 27, 2017
See: raspberrypi#397

kernel: bcm2835-sdhost: Adding overclocking option
kernel: bcm2835-mmc: Adding overclocking option
See: http://forum.kodi.tv/showthread.php?tid=224025&pid=2005396#pid2005396

kernel: config: Add CONFIG_CIFS_UPCALL
See: raspberrypi/linux#968

kernel: config: Add CONFIG_FB_SSD1307=m
See: raspberrypi/linux#969

firmware: di_adv: Fix memory leak of converted buffers
See: raspberrypi#429

firmware: arm_display: Fix initialisation of framebuffer struct when framebuffer base is passed in

firmware: hdmi: Tweak hdmi_mai_thresh for 192kHz audio
See: https://discourse.osmc.tv/t/rp2-multichannel-flac-playback/2627/28

firmware: vcsm: Update to header from kernel side
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants