Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPUS and Vorbis files cannot be played. #25

Closed
freedompath opened this issue Apr 4, 2024 · 5 comments
Closed

OPUS and Vorbis files cannot be played. #25

freedompath opened this issue Apr 4, 2024 · 5 comments

Comments

@freedompath
Copy link

When trying to play Opus or Vorbis files, the program skips to the next Mp3 file and only plays this file. However, the Vorbis or Opus titles and covers are displayed when the Mp3 file is played.

@rasmuslos
Copy link
Owner

You can now play any audio format supported by Jellyfin. The problem is that the duration is not correct.

This is caused by AVPlayer not accepting hls playlists when they come from the Jellyfin endpoint. All audio files have to be transcoded using the http protocol.
I wanted to swap out AVPlayer for AudioStreaming, it would also provide additional features like gapless playback and an equalizer, but it does not support dequeuing (dimitris-c/AudioStreaming#73) so we will have to wait until it is implemented before I can replace AVPlayer.

@freedompath
Copy link
Author

Ah I understand! Thank you very much for your quick response!

@gnattu
Copy link
Contributor

gnattu commented Apr 5, 2024

This is caused by AVPlayer not accepting hls playlists when they come from the Jellyfin endpoint. All audio files have to be transcoded using the http protocol.

Actually it is not. This is due to a bug in the 10.8 Jellyfin branch. The webclient's container request is in a wrong format and the server is having some problem dealing with the request. The server also has some internal logic errors that will cause it to return wrong response even if the request is valid. As you are using the request format from the webclient, then it will not work properly.

I added some comments to the commit:
b041cc4

After fixing those you will be able to get transcoded stream working with a 10.9 server. There is no need to replace the AVPlayer because it is more of a server-side bug.

@rasmuslos
Copy link
Owner

I added some comments on the commit 👍

@rasmuslos
Copy link
Owner

rasmuslos commented Apr 5, 2024

Also i forgot to update the download logic, but this has been resolved. If you download the tracks that have to be transcoded they will now be saved as an aac file. For local files the duration is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants