Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant line in vias_variance_decomp #652

Merged
merged 4 commits into from
Dec 28, 2019
Merged

Remove redundant line in vias_variance_decomp #652

merged 4 commits into from
Dec 28, 2019

Conversation

rasbt
Copy link
Owner

@rasbt rasbt commented Dec 27, 2019

Description

Removes redundant line in vias_variance_decomp

Related issues or pull requests

Fixes #649

Pull Request Checklist

  • Added a note about the modification or contribution to the ./docs/sources/CHANGELOG.md file (if applicable)
  • Added appropriate unit test functions in the ./mlxtend/*/tests directories (if applicable)
  • Modify documentation in the corresponding Jupyter Notebook under mlxtend/docs/sources/ (if applicable)
  • Ran PYTHONPATH='.' pytest ./mlxtend -sv and make sure that all unit tests pass (for small modifications, it might be sufficient to only run the specific test file, e.g., PYTHONPATH='.' pytest ./mlxtend/classifier/tests/test_stacking_cv_classifier.py -sv)
  • Checked for style issues by running flake8 ./mlxtend

@pep8speaks
Copy link

pep8speaks commented Dec 27, 2019

Hello @rasbt! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 178:53: E203 whitespace before ','

Comment last updated at 2019-12-27 23:20:29 UTC

@rasbt rasbt merged commit 1308f6b into master Dec 28, 2019
@rasbt rasbt deleted the redeclared branch November 12, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redeclared variable
2 participants