Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print out embeddings for more illustrative learning #481

Merged
merged 2 commits into from
Jan 13, 2025

Conversation

henrythe9th
Copy link
Contributor

The book only prints the shape but not the contents of the embeddings in ch02

image

Printing out embeddings helps to better illustrate learnings by showing the actual contents of the embeddings, and it doesn't take that much more space

image

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@rasbt
Copy link
Owner

rasbt commented Jan 13, 2025

Thanks for the suggestion, @henrythe9th. I totally agree with you here. Unfortunately, I had to trim the chapter per request by the publisher because it exceeded the allowed page limits for a chapter. Hence, I was focusing on the most important essentials. (Luckily it became a bit less strict in consequent chapters as it became clear that my style was a bit different from other books, but I still had to be careful to adhere to the suggested lengths.)

Long story short, I agree with you here. At the same time I don't want to make the modification like this in the notebook because it creates a deviation from the print version then, which could confuse some readers. As a compromise, I can add these lines in a "commented out" way with a suggestion to uncomment the line to see how the embeddings look like.

Anyways, thanks so much for taking the time to try to improve the book, and I hope you like it overall!

@rasbt rasbt merged commit b3150ee into rasbt:main Jan 13, 2025
8 checks passed
@henrythe9th
Copy link
Contributor Author

Sounds good and thank you for putting together this great book!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants