Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a skip_validation parameter in yaml reader #8333

Closed
kalkbrennerei opened this issue Mar 29, 2021 · 1 comment · Fixed by #8334
Closed

Introduce a skip_validation parameter in yaml reader #8333

kalkbrennerei opened this issue Mar 29, 2021 · 1 comment · Fixed by #8334
Assignees
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@kalkbrennerei
Copy link
Contributor

kalkbrennerei commented Mar 29, 2021

Description of Problem:
Currently yaml_story_reader::read_from_string always validates it's input.
This makes reading strings from the database (that were already validated) very slow, which e.g. happens in requests to GET /domainWarnings in rasa-x.

Overview of the Solution:
To speed up reading strings from the database we introduce a skip_validation parameter in yaml_story_reader::read_from_string and yaml_story_reader::read_from_file

Examples (if relevant):

Blockers (if relevant):

Definition of Done:

@kalkbrennerei kalkbrennerei added type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Mar 29, 2021
@kalkbrennerei kalkbrennerei self-assigned this Mar 29, 2021
@kalkbrennerei
Copy link
Contributor Author

rasa-x issue for context

@kalkbrennerei kalkbrennerei changed the title Introduce a skip_validation flag in yaml reader Introduce a skip_validation parameter in yaml reader Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant