-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a skip_validation
parameter to yaml story reader
#8334
Conversation
skip_validation
flag to yaml story reader
skip_validation
flag to yaml story readerskip_validation
parameter to yaml story reader
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Can we add a unit tests though? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Do we also need to update the Markdown implementation of the reader? We should add the parameter there as well, even if we do not use it.
Co-authored-by: Federico Tedin <[email protected]>
@federicotdn Since we'll drop markdown support, can we actually leave it out? Also I think that validation works differently in the markdown reader, so it might be tricky to add the |
I actually was thinking of only adding the parameter (either named |
ohhh sorry, I didn't read properly 🙈 |
Aaah I missed it! Yes exactly, that was what I was referring to 👍🏻 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's goo 🚀
closes #8333
Proposed changes:
skip_validation
flag toyaml_story_reader::read_from_file
andyaml_story_reader::read_from_string
Status (please check what you already did):
black
(please check Readme for instructions)