Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve domain slot ordering and multistrings while dumping #7418

Merged
merged 3 commits into from
Dec 4, 2020

Conversation

degiz
Copy link
Contributor

@degiz degiz commented Nov 30, 2020

Fix for https://github.com/RasaHQ/rasa-x/issues/3900 and RasaHQ/rasa-x-demo#27

Proposed changes:

  • Preserve ordering of domain slots while dumping
  • Preserve multi line strings in responses text key

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@degiz degiz requested review from a team and wochinge and removed request for a team November 30, 2020 18:15
@degiz degiz changed the title Preserve slot ordering Preserve domain slot ordering while dumping Nov 30, 2020
@degiz degiz changed the title Preserve domain slot ordering while dumping Preserve domain slot ordering and multistrings while dumping Dec 1, 2020
@degiz degiz requested review from wochinge and removed request for wochinge December 2, 2020 13:38
Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, concise fix!

Should this rather go into 2.1.x?

rasa/shared/core/domain.py Outdated Show resolved Hide resolved
rasa/shared/core/domain.py Outdated Show resolved Hide resolved
rasa/shared/core/domain.py Outdated Show resolved Hide resolved
tests/shared/core/test_domain.py Show resolved Hide resolved
@degiz degiz changed the base branch from master to 2.1.x December 3, 2020 12:57
@degiz degiz changed the base branch from 2.1.x to master December 3, 2020 12:58
@degiz degiz force-pushed the 3900_domain_dump_order branch from a5632d9 to 5c6bb49 Compare December 3, 2020 13:03
@degiz degiz changed the base branch from master to 2.1.x December 3, 2020 13:03
@degiz degiz changed the base branch from 2.1.x to master December 3, 2020 13:03
Add changelog

Preserve multiline strings in respones text inside domain

Preserve responses in NLU data as well

fix changelog entry

Take care of possible multiple text examples

Address PR comments
@degiz degiz force-pushed the 3900_domain_dump_order branch from 5c6bb49 to 573b9dc Compare December 3, 2020 13:12
@degiz degiz changed the base branch from master to 2.1.x December 3, 2020 13:12
@degiz degiz requested a review from wochinge December 3, 2020 13:13
@rasabot rasabot merged commit ae88eea into 2.1.x Dec 4, 2020
@rasabot rasabot deleted the 3900_domain_dump_order branch December 4, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants