-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rasa X changes the order of the form slots mapping #7460
Comments
What version are you using? Can you try updating to the latest version? It should be fixed there: #7418 |
@Ghostvv Thanks for your answer! I'm using 2.1.1, hadn't seen 2.1.2 and 2.1.3 were up (I'm monitoring the CHANGELOG file on master but I guess that's not enough for bug fixes) Will try updating to 2.1.3 |
oh, sorry, the fix is in rasa OSS, but the new version of rasa x is not released yet |
fixed in Rasa X 0.35 |
I think I am still experiencing this issue. Before running rasa x, there are no changes to the gazler> git diff domain.yml
gazler> rasa --version
Rasa Version : 2.2.9
Rasa SDK Version : 2.2.0
Rasa X Version : 0.35.1
Python Version : 3.6.9
Operating System : Linux-4.15.0-132-generic-x86_64-with-Ubuntu-18.04-bionic
Python Path : /home/gazler/.venv/bin/python3
gazler> rasa x &
gazler> git diff domain.yml diff --git a/rasa-bot/domain.yml b/rasa-bot/domain.yml
index 78e577d..cea7066 100644
--- a/rasa-bot/domain.yml
+++ b/rasa-bot/domain.yml
@@ -101,12 +101,12 @@ forms:
- type: from_text
channel_confirm:
- type: from_text
- note:
+ mention:
- type: from_text
mention_confirm:
- type: from_text
- mention:
- - type: from_text
mention_list:
- type: from_text
+ note:
+ - type: from_text
e2e_actions: [] |
Just wanted to update to confirm I am still seeing this issue with the following (latest) versions:
|
@Gazler Do you have an example domain which I could use to reproduce? 🙌🏻 |
@wochinge I created a default project and added the restaurant form, but re-ordered the form fields, so https://github.com/Gazler/rasa_x_form_order If you run |
Hi, I am also getting this issue in 0.37.0. It is making the process very hard because whenever I start rasa x it just messes up the form structure. Also, found out why it is messing up, its reordering form as per slot name. Can you guys make Rasa x not to do this? @wochinge Here are the screenshots before and after starting rasa x. Rasa Version: 2.3.4
Rasa SDK Version: 2.4.0
Rasa X Version: 0.37.0
Python Version: 3.7.5
Operating System: Linux-5.8.0-48-generic-x86_64-with-debian-bullseye-sid |
@Horizon733 Hello,I have same issue and could not solve.Is there any solution? |
Hi, I have the same problem, the slots are ordered in alphabetical order in the domain file after running rasa x
|
@wochinge any updates here? It seems like a hotfix that turns off the auto-sort that Rasa X does, which overrides the desired user behavior would fix this. I'm not sure why Rasa X would need to sort them alphabetically anyway. Without a fix, this effectively means using Rasa X breaks the use of forms in a bot entirely if you commit that "updated" domain file. Seems like this should be a high priority given forms are an essential part of a chatbot. Using Rasa X |
Thanks for bringing this up @pmbaumgartner ! @TyDunn I think somebody from Enable should take this one. Changing the order of form slots is bad as the bot asks for the slots in a different order (cc @DominikRos ). I think to make this clearer |
Yup, that's correct, form |
I think when Rasa x rewrites the yaml file it reorganizes forms with alphabetical order instead of writing it as it is |
Is this issue fixed? While training domain.yml changes to alphabetical order: Rasa version details:Rasa Version : 2.8.2 |
@degiz As you have closed this issue, in which version of Rasa X has this been fixed? I checked the changelog (https://rasa.com/docs/rasa-x/changelog/rasa-x-changelog) and cannot see any mention of it being fixed. |
Is there a workaround for this in the meantime? |
@DominikRos It would be quick and easy to cherry-pick this and do a micro release with this (sorry, should not have merged to |
Rasa version: 2.1.1
Rasa SDK version: 2.1.1
Rasa X version: 0.34.0
Python version: 3.7.9
Operating system: Ubuntu
Issue:
When starting Rasa X, the order of the slot mappings defined for forms in the domain file is automatically changed so that they are sorted alphabetically. Given that the order of the mapping changes the order in which the questions are asked by the bot within a form, this should not happen.
Command or request that led to error:
Content of domain file (domain.yml) (if relevant):
Before starting Rasa X
After starting Rasa X
The text was updated successfully, but these errors were encountered: