-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Response Selector training data format #6591
Conversation
@tmbo Can you please review the implementation logic? If the way in which the information exchange between NLU training data and Domain looks fine, I'll clean up the code, add tests and documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the approach looks good 👍 - I think this is a great improvement to the usability of the response selector ⭐
really excited about this 💯 |
Hey @dakshvar22! 👋 To run model regression tests, comment with the Tips 💡: The model regression test will be run on Tips 💡: Every time when you want to change a configuration you should edit the comment with the previous configuration. You can copy this in your comment and customize:
|
/modeltest include:
- dataset: ["Carbon Bot", "Sara"]
config: ["all"] |
The model regression tests have started. It might take a while, please be patient. Used configuration can be found in the comment. |
Commit: b7606ca, The full report is available as an artifact. Dataset:
Dataset:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only reviewed the rasa.shared
changes. They are good to go apart from the comments.
I didn't check the rest, but shouldn't we still support old stories which use respond_
instead of utter_
?
rasa/shared/nlu/constants.py
Outdated
@@ -24,3 +24,5 @@ | |||
ENTITY_ATTRIBUTE_START = "start" | |||
ENTITY_ATTRIBUTE_END = "end" | |||
NO_ENTITY_TAG = "O" | |||
|
|||
UTTER_PREFIX = "utter_" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move it to rasa.shared
then instead of re-adding this constant 👍
@wochinge Since this was an experimental feature we had the liberty to deprecate the old stuff. It's not just |
Proposed changes:
The new training data format for using retrieval intents looks like this -
nlu.yaml
responses.yaml -
domain.yaml
rules.yml
Two major changes -
utter_
prefixutter_
prefix and hence are more consistent with other utterance templates.Status (please check what you already did):
black
(please check Readme for instructions)