Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get metadata from REST channel #11311

Closed
wants to merge 9 commits into from
Closed

Conversation

rgstephens
Copy link
Contributor

Proposed changes:
@ancalita The REST channel should by default load the metadata key. I thought this worked in the past but can't seem to find when it was dropped.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@rgstephens rgstephens requested a review from a team as a code owner July 8, 2022 19:39
@rgstephens rgstephens requested review from sanchariGr and removed request for a team July 8, 2022 19:39
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot, I also couldn't find anything in closed PRs, docs or git blame, maybe it was never implemented 🤔
Could you please add a changelog entry and relevant test?

@rgstephens rgstephens enabled auto-merge (squash) July 14, 2022 23:33
@rgstephens rgstephens requested a review from ancalita July 16, 2022 20:49
rasa/core/channels/rest.py Show resolved Hide resolved
@rgstephens rgstephens requested a review from ancalita July 26, 2022 16:59
@rgstephens
Copy link
Contributor Author

@ancalita do you know if this will be merged into the next 3.2.x release?

@ancalita
Copy link
Member

ancalita commented Aug 8, 2022

@ancalita do you know if this will be merged into the next 3.2.x release?

I see this is targeting main actually, I'd recommend you rebase to 3.2.x and edit target branch on GH for the change to make it in the next micro release.

changelog/11311.fix.md Outdated Show resolved Hide resolved
@rgstephens rgstephens mentioned this pull request Aug 11, 2022
4 tasks
@rgstephens
Copy link
Contributor Author

Closing this. Rebasing on 3.2.x and opening #11436.

@rgstephens rgstephens closed this Aug 11, 2022
auto-merge was automatically disabled August 11, 2022 18:07

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants