Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REST metadata #11436

Merged
merged 5 commits into from
Aug 19, 2022
Merged

REST metadata #11436

merged 5 commits into from
Aug 19, 2022

Conversation

rgstephens
Copy link
Contributor

Replacement PR for #11311 re-based on 3.2.x. I'm targeting main for this PR since that's the GitHub default. Am I supposed to target 3.2.x?

Proposed changes:
The REST channel should by default load the metadata key. I thought this worked in the past but can't seem to find when it was dropped.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@rgstephens rgstephens requested a review from a team as a code owner August 11, 2022 18:07
@rgstephens rgstephens requested review from losterloh and removed request for a team August 11, 2022 18:07
@rgstephens rgstephens mentioned this pull request Aug 11, 2022
4 tasks
@ancalita
Copy link
Member

@rgstephens Likewise here, please target 3.2.x branch instead of main.

@rgstephens rgstephens changed the base branch from main to 3.2.x August 11, 2022 18:42
@rgstephens
Copy link
Contributor Author

Changed target branch to 3.2.x

Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly here, CI might get triggered with an empty commit.

@rgstephens rgstephens enabled auto-merge (squash) August 19, 2022 15:06
@rgstephens rgstephens merged commit aec6a94 into RasaHQ:3.2.x Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants