-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct & clarify parts of API spec #11130
Conversation
…HQ/rasa into ATO-95-update-http-api-docs-section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff 💯 Left a few clarifying questions 😄
Also worth looking into the JSON removal and why it's causing the test_evaluate_invalid_intent_model_file
to fail.
Co-authored-by: Anca Lita <[email protected]>
…HQ/rasa into ATO-95-update-http-api-docs-section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there 💯 Only asked for one unit test and probably some code can be removed.
🚀 A preview of the docs have been deployed at the following URL: https://11130--rasahq-docs-rasa-v2.netlify.app/docs/rasa |
Follow up issue is here #11151 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Proposed changes:
GET /status endpoint: Correct response schema for model_id - a string, not an object.
GET /conversations/{conversation_id}/tracker : Describe each of the enum options for include_events query parameter
POST & PUT /conversations/{conversation_id}/tracker/events : Events schema added for each event type
GET /conversations/{conversation_id}/story: Clarified the
all_sessions
query parameter and default behaviour.POST /model/test/intents : Remove JSON option, since the server was interpreting all input as YAML regardless of content-type header.
POST /model/parse: Explain what emulation_mode is and how it affects response results
Status (please check what you already did):
black
(please check Readme for instructions)