Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test stories returned by conversations/{convo_id}/story are blank when a session ends with a Restart event #11151

Closed
indam23 opened this issue May 27, 2022 · 1 comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@indam23
Copy link
Contributor

indam23 commented May 27, 2022

Rasa Open Source version

3.1.0

What happened?

When fetching test stories for all sessions from the conversations/{convo_id}/story endpoint, if the user had typed /restart and thus triggered a Restarted event, the story for that session will be blank.

I expected that each session would reflect the conversation up until the point of restart.

This happens because stories are constructed from applied_events, and applied events are automatically reset to an empty list when a Restarted event is encountered here.
One way the issue could be fixed is by changing how trackers are split into sessions in the get_trackers_for_conversation_sessions function, for example by moving action_restart and Restarted events to the beginning of a session instead of the end of the last session.

Command / Request

rasa run --enable api

# have a conversation with the bot including a few `/restart` messages

curl http://localhost:5005/conversations/default/story?all_sessions=true

Relevant log output

version: "3.1"
stories:
- story: test, story 1
  steps: []
- story: test, story 2
  steps: []
- story: test, story 3
  steps: []
- story: test, story 4
  steps: []
- story: test, story 5
  steps: []
@indam23 indam23 added type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels May 27, 2022
@sync-by-unito
Copy link

sync-by-unito bot commented Dec 16, 2022

➤ Maxime Verger commented:

💡 Heads up! We're moving issues to Jira: https://rasa-open-source.atlassian.net/browse/OSS.

From now on, this Jira board is the place where you can browse (without an account) and create issues (you'll need a free Jira account for that). This GitHub issue has already been migrated to Jira and will be closed on January 9th, 2023. Do not forget to subscribe to the corresponding Jira issue!

➡️ More information in the forum: https://forum.rasa.com/t/migration-of-rasa-oss-issues-to-jira/56569.

@m-vdb m-vdb closed this as completed Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:bug 🐛 Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

No branches or pull requests

3 participants
@m-vdb @indam23 and others