-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poetry for rasa-sdk 🎉 #145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work - looks a lot easier to maintain 🎉
I've added a couple comments regarding metadata that is missing and some open questions.
one more open question: does publishing the package using travis deploy still work? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @alwx 💯
Now it also includes changes from #146 Additional changes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Stoked for poetry :-)
6cfb6fc
to
d4b1a41
Compare
Things to do before merging this PR:
|
@alwx is the used password env already the correct one? |
@tmbo no, it's not — it should be updated first. |
I've encrypted the secret and suggested the change @alwx |
@alwx Why did we remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 💯
Proposed changes:
poetry
torasa-sdk
Status (please check what you already did):
black
(please check Readme for instructions)IMPORTANT: Things to do before merging this PR: