Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker images shouldn't run as root #141

Closed
2 tasks
wochinge opened this issue Jan 27, 2020 · 2 comments
Closed
2 tasks

Docker images shouldn't run as root #141

wochinge opened this issue Jan 27, 2020 · 2 comments
Assignees
Labels
area:rasa-sdk 🧑‍💻 Everything that touches our python Rasa SDK type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.

Comments

@wochinge
Copy link
Contributor

Same as our rasa and rasa-x images, the sdk image should not run as root user.
To fix this, we can build upon the work from #115 . Among the things which have to be wrapped up

  • use group id 0
  • make sure all used folders are accessible for this group 0 (we have to make it accessible to the group and not to the user, since OpenShift runs with a random user but with a fixed group id 0)
@wochinge wochinge added type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-sdk 🧑‍💻 Everything that touches our python Rasa SDK labels Jan 27, 2020
@alwx alwx self-assigned this Feb 5, 2020
@alwx
Copy link
Contributor

alwx commented Feb 10, 2020

Also we need to check this issue after we actually manage to run all the images as non-root:
RasaHQ/rasa-x-helm#18

@alwx
Copy link
Contributor

alwx commented Feb 12, 2020

Linked issues: #145 & RasaHQ/rasa#5223

(new Dockerfiles there use user 1001)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:rasa-sdk 🧑‍💻 Everything that touches our python Rasa SDK type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Development

No branches or pull requests

2 participants