Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ko: Use correct names for month and hour in Korean #2

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

tomasz1986
Copy link

ko: Use correct names for month and hour in Korean

Currently, "월" and "시" are used for "month" and "hour" in Korean. This
is incorrect in this particular usage, because these are only used when
speaking about concrete months and hours, e.g. "3월" means "March" and
"2시" means "2 o'clock".

Thus, change "월" to "달" and "시" to "시간", which are actually used when
counting months and hours.

Signed-off-by: Tomasz Wilczyński [email protected]

Currently, "월" and "시" are used for "month" and "hour" in Korean. This
is incorrect in this particular usage, because these are only used when
speaking about concrete months and hours, e.g. "3월" means "March" and
"2시" means "2 o'clock".

Thus, change "월" to "달" and "시" to "시간", which are actually used when
counting months and hours.

Signed-off-by: Tomasz Wilczyński <[email protected]>
@rasa
Copy link
Owner

rasa commented Sep 5, 2024

ko: Use correct names for month and hour in Korean

@tomasz1986 I used chatgpt on many of the translations, so I'm not surprised it got this wrong.

@rasa rasa merged commit 38dcb03 into rasa:main Sep 12, 2024
1 check passed
@tomasz1986 tomasz1986 deleted the fix-Korean-hour branch September 15, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants