Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support managedservice in the cli #69

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

pallabpain
Copy link
Contributor

@pallabpain pallabpain commented Nov 17, 2022

This PR adds support for managedservices in the cli. You can create or delete a managedservice instance with the rio apply command.

【 code 】
→ pipenv run python -m riocli managedservice
Usage: rio managedservice [OPTIONS] COMMAND [ARGS]...

Managed services on rapyuta.io

These are services that are provisioned by rapyuta.io and hosted on either
cloud or SRE backed infrastructure. An example of such a service is
elasticsearch.

Options:
--help Show this message and exit.

Commands:
inspect Fetch a managedservice instance
list List all the managedservice instances
providers List available managedservice providers

【 end code 】

asciicast

┆Issue is synchronized with this Wrike task

@pallabpain pallabpain self-assigned this Nov 17, 2022
@pallabpain pallabpain changed the base branch from main to devel November 17, 2022 11:11
@pallabpain pallabpain linked an issue Nov 17, 2022 that may be closed by this pull request
@pallabpain pallabpain added this to the v0.6.0 milestone Nov 23, 2022
@pallabpain pallabpain added the ✨ feature A new feature addition to the CLI label Nov 23, 2022
jsonschema/managedservice-schema.yaml Outdated Show resolved Hide resolved
riocli/apply/resolver.py Show resolved Hide resolved
riocli/auth/staging.py Show resolved Hide resolved
riocli/deployment/model.py Show resolved Hide resolved
riocli/managedservice/__init__.py Outdated Show resolved Hide resolved
riocli/managedservice/util.py Show resolved Hide resolved
riocli/managedservice/util.py Outdated Show resolved Hide resolved
riocli/managedservice/util.py Show resolved Hide resolved
riocli/managedservice/util.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@pallabpain pallabpain force-pushed the feature/managed-services branch from 3b0929e to d446a21 Compare December 6, 2022 10:16
Copy link
Member

@ankitrgadiya ankitrgadiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment that we can take as future improvement. Also, please update the commit message to include the scope part.

https://www.conventionalcommits.org/en/v1.0.0/#commit-message-with-scope

riocli/managedservice/util.py Show resolved Hide resolved
This commit introduces support for rapyuta.io managed services.

Usage: rio managedservice [OPTIONS] COMMAND [ARGS]...

  Managed Services on rapyuta.io

  With managed services on rapyuta.io, you can provision services like
  elasticsearch, etc. on-demand and use them with your deployments.

Options:
  --help  Show this message and exit.

Commands:
  inspect    Inspect a managedservice instance
  list       List all the managedservice instances
  providers  List available managedservice providers

You can create and delete managed services with the rio apply command
and it currently doesn't have a directly CLI option.

Reviewed By: Ankit Gadiya
@pallabpain pallabpain force-pushed the feature/managed-services branch from d446a21 to 7aff123 Compare December 6, 2022 12:22
@pallabpain pallabpain merged commit e140c4c into devel Dec 6, 2022
@rr-github-ci-user
Copy link
Collaborator

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@rr-github-ci-user rr-github-ci-user added the 🎉 release This is a release item. label Dec 14, 2022
@ankitrgadiya ankitrgadiya deleted the feature/managed-services branch June 28, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature A new feature addition to the CLI 🎉 release This is a release item.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Add support for managedservices
3 participants