Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apply improvements and milestone 4.0.0 requests #42

Merged

Conversation

wiresurfer
Copy link
Contributor

@wiresurfer wiresurfer commented Aug 25, 2022

@wiresurfer
Copy link
Contributor Author

The order of merge will be

  1. apply improvements and milestone 4.0.0 requests #42 feature/apply-feedback-improvement merges into --> feature/apply-command
  2. feat(apply): adds support for apply command #30 feature/apply-command merges into minor bugfix
  3. fix(network): handles network not found correctly #43 merge apply-command with bugfixes into devel.
  4. Create a devel -> master PR and do a release.

cc @ankitrgadiya documenting it here.

@wiresurfer wiresurfer added this to the v0.5.0 milestone Aug 25, 2022
@wiresurfer wiresurfer modified the milestones: v0.5.0, v0.4.0 Aug 26, 2022
@wiresurfer wiresurfer changed the title apply improvements and milestone 5.0.0 requests apply improvements and milestone 4.0.0 requests Sep 2, 2022
@ankitrgadiya
Copy link
Member

ankitrgadiya commented Sep 15, 2022

We figured out that device-schema is incorrect. Please apply this patch and re-generate the validations.

cc: @shiv-mohith

diff --git a/jsonschema/device-schema.yaml b/jsonschema/device-schema.yaml
index bdc41cd..53055c5 100644
--- a/jsonschema/device-schema.yaml
+++ b/jsonschema/device-schema.yaml
@@ -57,29 +57,40 @@ definitions:
       docker:
         oneOf:
           - properties:
-              enabled:
-                enum:
-                  - False
+              docker:
+                type: object
+                properties:
+                  enabled:
+                    enum:
+                      - False
           - properties:
-              enabled:
-                enum:
-                  - True
-              rosbagMountPath:
-                type: string
-                default: /opt/rapyuta/volumes/rosbag
+              docker:
+                type: object
+                properties:
+                  enabled:
+                    enum:
+                      - True
+                  rosbagMountPath:
+                    type: string
+                    default: /opt/rapyuta/volumes/rosbag
       preinstalled:
         oneOf:
           - properties:
-              enabled:
-                enum:
-                  - False
+              preinstalled:
+                type: object
+                properties:
+                  enabled:
+                    enum:
+                      - False
           - properties:
-              enabled:
-                enum:
-                  - True
-              catkinWorkspace:
-                type: string
-
+              preinstalled:
+                type: object
+                properties:
+                  enabled:
+                    enum:
+                      - True
+                  catkinWorkspace:
+                    type: string
   stringMap:
     type: object
     additionalProperties:

@@ -0,0 +1,15 @@
global:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get rid of the kiba-robots and all other directories under examples. As discussed, these are housed under rapyuta-charts/manifests anyways.

riocli/apply/__init__.py Outdated Show resolved Hide resolved
riocli/apply/__init__.py Outdated Show resolved Hide resolved
riocli/apply/explain.py Outdated Show resolved Hide resolved
riocli/utils/mermaid.py Outdated Show resolved Hide resolved
riocli/apply/parse.py Outdated Show resolved Hide resolved
riocli/apply/parse.py Outdated Show resolved Hide resolved
riocli/apply/parse.py Show resolved Hide resolved
riocli/deployment/model.py Show resolved Hide resolved
riocli/device/validation.py Show resolved Hide resolved
@wiresurfer
Copy link
Contributor Author

@ankitrgadiya have added both sync and assync fullfilers for both rio charts apply and rio-apply.
have added an error message when an apply of one object fails.

take a look and let me know if you need any further changes

@ankitrgadiya ankitrgadiya merged commit e47dd3e into feature/apply-command Sep 27, 2022
@rr-github-ci-user
Copy link
Collaborator

🎉 This PR is included in version 0.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@rr-github-ci-user rr-github-ci-user added the 🎉 release This is a release item. label Oct 3, 2022
@ankitrgadiya ankitrgadiya deleted the feature/apply-feedback-improvements branch April 20, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 release This is a release item.
Projects
None yet
5 participants