Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(device): report online devices only #382

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

pallabpain
Copy link
Member

@pallabpain pallabpain commented Oct 29, 2024

Description

The device report command should only work for online devices. This commit adds the check to ensure that.

02:46:32 (.venv) pallab@pop-os rapyuta-io-cli ±|fix/do-not-report-registered-device|
→ uv run rio device report registered
⚠️ Device is not online. Skipping report.

@pallabpain pallabpain requested review from a team as code owners October 29, 2024 09:08
@pallabpain pallabpain self-assigned this Oct 29, 2024
Copy link

github-actions bot commented Oct 29, 2024

🤖 Pull Request Artifacts (#11570785445) 🎉

The device report command should only work for online devices. This
commit adds the check to ensure that.
@pallabpain pallabpain force-pushed the fix/do-not-report-registered-device branch from 73e50fb to d4b2d9d Compare October 29, 2024 09:17
@pallabpain pallabpain added the 🐛 bug Something isn't working label Oct 29, 2024
@pallabpain pallabpain merged commit bfe7bb3 into devel Oct 29, 2024
11 checks passed
rr-github-ci-user pushed a commit that referenced this pull request Nov 14, 2024
# [9.2.0](v9.1.3...v9.2.0) (2024-11-14)

### Bug Fixes

* **device:** report online devices only ([#382](#382)) ([bfe7bb3](bfe7bb3))
* **organization:** fixes key error when no org is selected ([#383](#383)) ([29476ff](29476ff))

### Features

* **apply:** adds template func to get interface ip ([#379](#379)) ([d370826](d370826))
@rr-github-ci-user
Copy link
Collaborator

🎉 This PR is included in version 9.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pallabpain pallabpain deleted the fix/do-not-report-registered-device branch December 12, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants