fix(apply): deep merge secrets and values #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pallabpain
force-pushed
the
fix/merge-values
branch
from
452e025 to
352427d
Compare
|
🤖 Pull Request Artifacts (#11453989548) 🎉 |
pallabpain
force-pushed
the
fix/merge-values
branch
from
352427d to
d34a665
Compare
ankitrgadiya
approved these changes
Oct 22, 2024
|
🎉 This PR is included in version 9.1.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While adding the support for multiple value and secret files, I made the silly mistake of not performing a deep merge on the dicts. This PR fixes the issue.