fix(project): updates subnet when vpn is already enabled #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rio project features vpn command does not update the subnet if the VPN is already enabled. The reason is a check that returns if the current state is already the desired one. This commit removes the check and allows an update to happen irrespective and thus allowing the subnet range updates to work. Wrike Ticket: https://www.wrike.com/open.htm?id=1418307735
|
🤖 Pull Request Artifacts (#9700274730) 🎉 |
rrkumarshikhar
approved these changes
Jun 28, 2024
amitsingh21
approved these changes
Jul 2, 2024
rr-github-ci-user
pushed a commit
that referenced
this pull request
Jul 4, 2024
# [7.6.0](v7.5.0...v7.6.0) (2024-07-04) ### Bug Fixes * **device:** sets device labels correctly ([#329](#329)) ([a3ac73d](a3ac73d)) * **device:** sets highperf label on virtual device ([#328](#328)) ([1eb7906](1eb7906)) * **project:** updates subnet when vpn is already enabled ([#324](#324)) ([e8d553b](e8d553b)) ### Features * **configtree:** add export command ([6f236ae](6f236ae)) * **configtree:** add support for diff ([7df605e](7df605e)) * **configtree:** add support for merge ([a1d273f](a1d273f)) * **configtree:** add support for milestone ([6ada3f7](6ada3f7)) * **device:** supports onboarding hwil devices via device manifest ([#323](#323)) ([7c257f1](7c257f1)) * **hwil:** implements hwil command ([#319](#319)) ([3e24b0b](3e24b0b))
|
🎉 This PR is included in version 7.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The rio project features vpn command does not update the subnet if the VPN is already enabled. The reason is a check that returns if the current state is already the desired one.
This commit removes the check and allows an update to happen irrespective and thus allowing the subnet range updates to work.
Wrike Ticket: https://www.wrike.com/open.htm?id=1418307735