feat(auth): adds support for non-interactive login #32
Conversation
ankitrgadiya
force-pushed
the
feature/non-interactive-login
branch
from
61a85a7 to
d67eaa0
Compare
ankitrgadiya
force-pushed
the
feature/non-interactive-login
branch
from
d67eaa0 to
1b2f8ad
Compare
| @@ -47,6 +51,9 @@ def login(ctx: click.Context, email: str, password: str): | |||
| click.echo("[Warning] rio already has a config file present") | |||
There was a problem hiding this comment.
Couple of comments.
I am assuming the project variable is implicitly setting the project key in ctx.obj.data.
-
Is that true? If yes, then we should still explicitly set it just like we set set email_id, password, auth_token, for readability.
-
Line 47-49. Can we have the ctx.obj.save before the echo. in case the save fails, we will have a very confusing order of messages. Ideally with spinner: ctx.obj.save() click.echo
-
instead of --no-project flag. can we call it something more indicative. --interactive/--no-interactive flag. then we can pseudo-code it with. if interactive. then ask email, if not given, ask password if not give, select project if not given. if no-interactive, check the three args [email, password, project] raise error if anything is missing. set the config.
# [0.4.0](v0.3.1...v0.4.0) (2022-10-03) ### Bug Fixes * **network:** handles network not found correctly ([#22](#22)) ([b38c7a0](b38c7a0)) * **shell:** Fixed a bug which causes REPL to close in case of exception. ([e8dc6f0](e8dc6f0)) ### Features * **apply:** adds support for apply command ([#30](#30)) ([f6ae40d](f6ae40d)), closes [#39](#39) * **auth:** adds support for non-interactive login ([#32](#32)) ([8c8c460](8c8c460)) * **project:** adds highlight for current project in list output ([ce348da](ce348da)) * **shell:** adds improvements in repl session ([b7a481e](b7a481e))
Resolves #24
┆Issue is synchronized with this Wrike task