fix(secret): corrects the corresponding find functor #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Pull Request Artifacts (#9032163504) 🎉 |
pallabpain
changed the title
pallabpain
changed the title
pallabpain
changed the title
pallabpain
requested changes
May 10, 2024
|
🤖 Pull Request Artifacts (#9032932555) 🎉 |
Due to a recent refactor in the v2 client library, the list secrets function now returns the entire secret objects instead of just reading the metadata in the previous implementation. This changed object altogther and the way other sections of code fetched the secret name. This commit addresses the issue by correcting the find functions and other methods where secret name is referred to.
pallabpain
approved these changes
May 11, 2024
|
🤖 Pull Request Artifacts (#9044380473) 🎉 |
rr-github-ci-user
pushed a commit
that referenced
this pull request
May 16, 2024
# [7.4.0](v7.3.3...v7.4.0) (2024-05-16) ### Bug Fixes * **configtree:** handle project-level trees correctly in commit sub-command ([6899711](6899711)) * **configtree:** replace --project with --organization flag ([ab3e5ca](ab3e5ca)) * corrects the with_org usage ([29d4ae4](29d4ae4)) * **secret:** corrects corresponding find functions ([#301](#301)) ([41e287b](41e287b)) ### Features * **configtree:** add support for key-level Metadata ([5b7c1bb](5b7c1bb)) * **configtrees:** add support for interacting with Config trees ([f979128](f979128)) * **configtree:** support exporting YAML files in `import` command ([f7f145f](f7f145f)) * **graph:** add support for Graphviz ([760d6c0](760d6c0)) * **state:** implement StateFile to store intermediate state ([3302133](3302133)) * **vpn:** add support for registering machine for Android or iOS ([c385bea](c385bea))
|
🎉 This PR is included in version 7.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to a recent refactor in the v2 client library,
the list secrets function now returns the entire
secret objects instead of just reading the metadata
in the previous implementation. This changed object
altogther and the way other sections of code fetched
the secret name.
This commit addresses the issue by correcting the
find functions and other methods where secret name is
referred to.