fix(v2client): updates limits for list secrets and routes #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing limits for list secrets and static routes was set to 10 which is quite low. This leads to increased number of calls to the apiserver. This commit increases the limit to 50, reducing the number of calls required to fetch all the items.
|
🤖 Pull Request Artifacts (#7825748545) 🎉 |
RomilShah
approved these changes
Feb 8, 2024
amitsingh21
approved these changes
Feb 8, 2024
rr-github-ci-user
pushed a commit
that referenced
this pull request
Feb 14, 2024
# [7.1.0](v7.0.3...v7.1.0) (2024-02-14) ### Bug Fixes * corrects regex for fetching resources ([1d3c75e](1d3c75e)) * sets default confirmation action to 'No' ([b3348af](b3348af)) * **v2client:** updates limits for list secrets and routes ([#270](#270)) ([862fdfc](862fdfc)) ### Features * **explain:** updates examples for region support and env var inconsistency ([#273](#273)) ([62a2828](62a2828)) ### Reverts * **explain:** adds network examples for us region ([#276](#276)) ([3593def](3593def))
|
🎉 This PR is included in version 7.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
RomilShah
pushed a commit
that referenced
this pull request
Apr 23, 2024
The existing limits for list secrets and static routes was set to 10 which is quite low. This leads to increased number of calls to the apiserver. This commit increases the limit to 50, reducing the number of calls required to fetch all the items.
RomilShah
pushed a commit
that referenced
this pull request
Apr 23, 2024
# [7.1.0](v7.0.3...v7.1.0) (2024-02-14) ### Bug Fixes * corrects regex for fetching resources ([1d3c75e](1d3c75e)) * sets default confirmation action to 'No' ([b3348af](b3348af)) * **v2client:** updates limits for list secrets and routes ([#270](#270)) ([862fdfc](862fdfc)) ### Features * **explain:** updates examples for region support and env var inconsistency ([#273](#273)) ([62a2828](62a2828)) ### Reverts * **explain:** adds network examples for us region ([#276](#276)) ([3593def](3593def))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The existing limits for list secrets and static routes were set to 10 which is quite low. This leads to an increased number of calls to the apiserver. This commit increases the limit to 50, reducing the calls required to fetch all the items.