Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix: miscellaneous bug fixes #250

Merged
merged 7 commits into from
Jan 19, 2024
Merged

🐛 fix: miscellaneous bug fixes #250

merged 7 commits into from
Jan 19, 2024

Conversation

RomilShah
Copy link
Contributor

@RomilShah RomilShah commented Jan 16, 2024 •
edited
Loading

Test manifests:

adds validation for applying cloud disk on device deployment

---
apiVersion: apiextensions.rapyuta.io/v1
kind: Package
metadata:
  description: Sootballs Printer Cups package
  labels:
    app: printer_cups
  name: sootballs_printer_cups
  version: 2.0.1-kokubu
spec:
  device:
    arch: amd64
    restart: always
  executables:
  - docker:
      image: nginx
    name: cups
    runAsBash: false
    type: docker
  runtime: device
#---
apiVersion: apiextensions.rapyuta.io/v1
kind: Deployment
metadata:
  depends:
    kind: package
    nameOrGUID: pkg-oytmqdbzeajwyxsgczeawfzd
    version: 2.0.1-kokubu
  labels:
    app: printer_cups
  name: sootballs_printer_cups
spec:
  device:
    depends:
      kind: device
      nameOrGUID: romil-v3
  runtime: device
  volumes:
  - execName: cups
    mountPath: /etc/cups/printers.conf
    subPath: /opt/rapyuta/configs/cups/printers.conf
#    depends: #not for device
#      kind: disk
#      nameOrGUID: "romil"

test Resolves misleading execution of command in wrong project in case of changing organization

rio organization select Rapyuta2  --no-interactive
rio device create biswa --runtime dockercompose

@RomilShah RomilShah requested review from a team as code owners January 16, 2024 11:05
@github-actions GitHub Actions
Copy link

🤖 Pull Request Artifacts (#7540675768) 🎉

@github-actions GitHub Actions
Copy link

🤖 Pull Request Artifacts (#7541058598) 🎉

@pallabpain pallabpain changed the title Fix/multiple bugs 🐛 fix: miscellaneous bug fixes Jan 16, 2024
@pallabpain pallabpain changed the title 🐛 fix: miscellaneous bug fixes 🐛 fix: miscellaneous bug fixes Jan 16, 2024
@pallabpain pallabpain self-assigned this Jan 16, 2024
@pallabpain pallabpain added the 🐛 bug Something isn't working label Jan 16, 2024
pallabpain
pallabpain suggested changes Jan 16, 2024
View reviewed changes
riocli/device/delete.py Outdated Show resolved Hide resolved
riocli/organization/select.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

🤖 Pull Request Artifacts (#7554542998) 🎉

@github-actions GitHub Actions
Copy link

🤖 Pull Request Artifacts (#7556975087) 🎉

pallabpain
pallabpain reviewed Jan 18, 2024
View reviewed changes
Copy link
Contributor

@pallabpain pallabpain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you are ready with all the fixes, please discuss the commit messages before merging.

@github-actions GitHub Actions
Copy link

🤖 Pull Request Artifacts (#7569966385) 🎉

@github-actions GitHub Actions
Copy link

🤖 Pull Request Artifacts (#7582459778) 🎉

@RomilShah @pallabpain
fix(device): improves message when devices deleted successfully
c0bd53b 
Wrike Ticket: https://www.wrike.com/open.htm?id=1270437842
@RomilShah @pallabpain
fix(secret): adds secret name length validation
f2eb2e5 
This commit adds a validation on the secret name length by setting it to
a maximum 253 characters.

Wrike Ticket: https://www.wrike.com/open.htm?id=1238536095
@RomilShah @pallabpain
fix(jsonschema): disallows additional properties for device volumes
80d388d 
This commit sets additionalProperties=false for device volume spec.

Wrike Ticket: https://www.wrike.com/open.htm?id=1249710356
@RomilShah @pallabpain
fix(organization): empties project when organization is selected non-…
dcff4fc 
…interactively

Wrike Ticket: https://www.wrike.com/open.htm?id=1230579582
@RomilShah @pallabpain
fix(apply): adds deploymentId as an option in GUID_KEYS
cc3916b 
Deployment depends in manifest was not working when the deployment guid
was used instead of the deployment name in nameOrGUID. This was
happening because we were not accounting for 'deploymentId' for
dependent deployments and hence, apply was failing with the error that
there is a missing resource in the manifest.

This commit ensures that we read the right key and populate the
dependent deployment correctly in the apply hierarchy.

Wrike Ticket: https://www.wrike.com/open.htm?id=1249688483
@RomilShah @pallabpain
fix(jsonschema): removes default device deployment restart policy
a90862a 
This default in the deployments was conflicting with the restart policy
set in the package. For example, if you set restart policy = never in
the package and you do not set the policy in the deployment manifest, it
still overrides the package value and sets the default.

Wrike Ticket:  https://www.wrike.com/open.htm?id=1205809047
@RomilShah @pallabpain
fix(jsonschema): adds validation on disk volume mount path
e1058d8 
Wrike Ticket: https://www.wrike.com/open.htm?id=1249708001
@pallabpain pallabpain assigned RomilShah and unassigned pallabpain Jan 19, 2024
@github-actions GitHub Actions
Copy link

🤖 Pull Request Artifacts (#7582664300) 🎉

@pallabpain pallabpain merged commit 9332b45 into devel Jan 19, 2024
7 checks passed
@pallabpain pallabpain deleted the fix/multiple-bugs branch January 24, 2024 10:27
@rr-github-ci-user
Copy link
Collaborator

🎉 This PR is included in version 7.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smrutisenapati smrutisenapati smrutisenapati approved these changes

@pallabpain pallabpain pallabpain approved these changes

@ankitrgadiya ankitrgadiya Awaiting requested review from ankitrgadiya ankitrgadiya is a code owner automatically assigned from rapyuta-robotics/io-cli-owner

Assignees

@RomilShah RomilShah

Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RomilShah @rr-github-ci-user @pallabpain @smrutisenapati