Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(organization): fixes key error when no org is selected #383

Merged
merged 1 commit into from
Nov 5, 2024
Merged

fix(organization): fixes key error when no org is selected #383

merged 1 commit into from
Nov 5, 2024

Conversation

pallabpain
Copy link
Member

@pallabpain pallabpain commented Nov 5, 2024 •
edited
Loading

Description

When we login with auth token in silent mode, there's no org selected. The config has no org present either. This breaks the list command that tries to fetch the selected org from config to highlight it in the output.

03:26:43 pallab@pop-os rr_flaptter_deploy ±|devel ✗|
→ rio organization list
'organization_id'
03:26:51 pallab@pop-os rr_flaptter_deploy ±|devel ✗|
→ cat ~/.config/rio-cli/config.json 
───────┬────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
       │ File: /home/pallab/.config/rio-cli/config.json
───────┼────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   1   │ {"hwil_auth_token": "TOKEN", "machine_id": "63eed7ba-49f7-4de5-8811-95f46bc88137", "email_id": "[email protected]", "auth_token": "TOKEN"}
───────┴────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────

@pallabpain pallabpain requested review from a team as code owners November 5, 2024 09:59
@pallabpain pallabpain self-assigned this Nov 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

🤖 Pull Request Artifacts (#11681753209) 🎉

@pallabpain pallabpain added the 🐛 bug Something isn't working label Nov 5, 2024
@pallabpain pallabpain merged commit 29476ff into devel Nov 5, 2024
11 checks passed
rr-github-ci-user pushed a commit that referenced this pull request Nov 14, 2024
@semantic-release-bot
chore(release): 9.2.0 [skip ci]
b010228 
# [9.2.0](v9.1.3...v9.2.0) (2024-11-14)

### Bug Fixes

* **device:** report online devices only ([#382](#382)) ([bfe7bb3](bfe7bb3))
* **organization:** fixes key error when no org is selected ([#383](#383)) ([29476ff](29476ff))

### Features

* **apply:** adds template func to get interface ip ([#379](#379)) ([d370826](d370826))
@rr-github-ci-user
Copy link
Collaborator

🎉 This PR is included in version 9.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pallabpain pallabpain deleted the fix/auth-token-login branch December 12, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitrgadiya ankitrgadiya ankitrgadiya approved these changes

@smrutisenapati smrutisenapati Awaiting requested review from smrutisenapati smrutisenapati is a code owner automatically assigned from rapyuta-robotics/io-first-reviewer

Assignees

@pallabpain pallabpain

Labels
🐛 bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pallabpain @rr-github-ci-user @ankitrgadiya