Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(device): sets highperf label on virtual device #328

Merged
merged 1 commit into from
Jul 3, 2024
Merged

fix(device): sets highperf label on virtual device #328

merged 1 commit into from
Jul 3, 2024

Conversation

pallabpain
Copy link
Member

@pallabpain pallabpain commented Jul 3, 2024 •
edited
Loading

Description

The highperf label is not being set when set to True in the manifest. This commit fixes the issue.

Testing

apiVersion: "apiextensions.rapyuta.io/v1"
kind: "Device"
metadata:
  name: "test01"
  labels:
    purpose: testing
    app: test
spec:
  python: "3"
  rosDistro: "melodic"
  virtual:
    enabled: True
    product: "sootballs"
    arch: "amd64"
    os: "ubuntu"
    codename: "focal"
    highperf: true
  docker:
    enabled: True # Required
    rosbagMountPath: "/opt/rapyuta/volumes/rosbag"

@pallabpain
fix(device): sets highperf label on virtual device
bb1bb7b 
The highperf label is not being set when set to True in the manifest.
This commit fixes the issue.
@pallabpain pallabpain requested review from a team as code owners July 3, 2024 06:30
@pallabpain pallabpain self-assigned this Jul 3, 2024
@pallabpain pallabpain added the 🐛 bug Something isn't working label Jul 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

🤖 Pull Request Artifacts (#9772978533) 🎉

@pallabpain pallabpain merged commit 1eb7906 into devel Jul 3, 2024
6 checks passed
rr-github-ci-user pushed a commit that referenced this pull request Jul 4, 2024
@semantic-release-bot
chore(release): 7.6.0 [skip ci]
cfefc76 
# [7.6.0](v7.5.0...v7.6.0) (2024-07-04)

### Bug Fixes

* **device:** sets device labels correctly ([#329](#329)) ([a3ac73d](a3ac73d))
* **device:** sets highperf label on virtual device ([#328](#328)) ([1eb7906](1eb7906))
* **project:** updates subnet when vpn is already enabled ([#324](#324)) ([e8d553b](e8d553b))

### Features

* **configtree:** add export command ([6f236ae](6f236ae))
* **configtree:** add support for diff ([7df605e](7df605e))
* **configtree:** add support for merge ([a1d273f](a1d273f))
* **configtree:** add support for milestone ([6ada3f7](6ada3f7))
* **device:** supports onboarding hwil devices via device manifest ([#323](#323)) ([7c257f1](7c257f1))
* **hwil:** implements hwil command ([#319](#319)) ([3e24b0b](3e24b0b))
@rr-github-ci-user
Copy link
Collaborator

🎉 This PR is included in version 7.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pallabpain pallabpain deleted the fix/hwil-device-manifest branch October 14, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitsingh21 amitsingh21 amitsingh21 approved these changes

@RomilShah RomilShah Awaiting requested review from RomilShah RomilShah is a code owner automatically assigned from rapyuta-robotics/io-first-reviewer

Assignees

@pallabpain pallabpain

Labels
🐛 bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pallabpain @rr-github-ci-user @amitsingh21