Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hwil): implements hwil command #319

Merged
merged 2 commits into from
Jun 14, 2024
Merged

feat(hwil): implements hwil command #319

merged 2 commits into from
Jun 14, 2024

Conversation

rrkumarshikhar
Copy link
Contributor

@rrkumarshikhar rrkumarshikhar commented Jun 10, 2024

Description

This pull request introduces the hwil command to manage hardware-in-loop devices.

Usage

Usage: rio hwil [OPTIONS] COMMAND [ARGS]...

  Manage Hardware-in-the-Loop (HWIL) devices

Options:
  --help  Show this message and exit.

Commands:
  create   Create a new hardware-in-the-loop device.
  delete   Delete one or more devices
  execute  Execute
  inspect  Inspect the hardware-in-the-loop device.
  list     Lists hardware-in-loop devices.
  login    Log in to HWIL.
  ssh      SSH into the hardware-in-the-loop device.

Demo

Managing devices

asciicast

Execute and SSH Command

asciicast

@rrkumarshikhar rrkumarshikhar requested review from a team as code owners June 10, 2024 06:34
@rrkumarshikhar rrkumarshikhar requested review from RomilShah and removed request for a team June 10, 2024 06:34
Copy link

🤖 Pull Request Artifacts (#9443585226) 🎉

@rrkumarshikhar rrkumarshikhar changed the title Add/hwil subcommands [WIP] add hwil subcommands Jun 10, 2024
@pallabpain pallabpain changed the title [WIP] add hwil subcommands ✨ feat(hwil): implements hwil command Jun 10, 2024
@pallabpain pallabpain changed the title ✨ feat(hwil): implements hwil command feat(hwil): implements hwil command Jun 10, 2024
Copy link
Member

@pallabpain pallabpain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rrkumarshikhar Before reviews begin, please rebase the PRs against devel since this implementation is independent and we can get it out by the 12th.

@rrkumarshikhar rrkumarshikhar force-pushed the add/hwil-subcommands branch 4 times, most recently from 31a4dca to d3f6727 Compare June 10, 2024 10:33
@pallabpain pallabpain changed the base branch from feat/hwil to devel June 10, 2024 12:46
@rrkumarshikhar rrkumarshikhar force-pushed the add/hwil-subcommands branch 2 times, most recently from cdb770c to adc91e9 Compare June 10, 2024 13:59
@pallabpain pallabpain added the ✨ feature A new feature addition to the CLI label Jun 11, 2024
@pallabpain pallabpain force-pushed the add/hwil-subcommands branch from e88a285 to 593fa79 Compare June 12, 2024 18:07
@pallabpain pallabpain self-assigned this Jun 12, 2024
@pallabpain pallabpain force-pushed the add/hwil-subcommands branch from 593fa79 to 1913c20 Compare June 12, 2024 18:12
@pallabpain pallabpain removed the request for review from RomilShah June 12, 2024 18:32
@pallabpain pallabpain force-pushed the add/hwil-subcommands branch 2 times, most recently from fa6a38c to e167a74 Compare June 13, 2024 11:01
Copy link
Member

@pallabpain pallabpain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankitrgadiya Implemented execute and ssh as discussed.

@rapyuta-robotics rapyuta-robotics deleted a comment from github-actions bot Jun 13, 2024
@rapyuta-robotics rapyuta-robotics deleted a comment from github-actions bot Jun 13, 2024
@rapyuta-robotics rapyuta-robotics deleted a comment from github-actions bot Jun 13, 2024
@rapyuta-robotics rapyuta-robotics deleted a comment from github-actions bot Jun 13, 2024
@rapyuta-robotics rapyuta-robotics deleted a comment from github-actions bot Jun 13, 2024
Copy link

🤖 Pull Request Artifacts (#9502251240) 🎉

@rapyuta-robotics rapyuta-robotics deleted a comment from github-actions bot Jun 13, 2024
@rapyuta-robotics rapyuta-robotics deleted a comment from github-actions bot Jun 13, 2024
@rapyuta-robotics rapyuta-robotics deleted a comment from github-actions bot Jun 13, 2024
@rapyuta-robotics rapyuta-robotics deleted a comment from github-actions bot Jun 13, 2024
@rapyuta-robotics rapyuta-robotics deleted a comment from github-actions bot Jun 13, 2024
@rapyuta-robotics rapyuta-robotics deleted a comment from github-actions bot Jun 13, 2024
@rapyuta-robotics rapyuta-robotics deleted a comment from github-actions bot Jun 13, 2024
@rapyuta-robotics rapyuta-robotics deleted a comment from github-actions bot Jun 13, 2024
@pallabpain pallabpain force-pushed the add/hwil-subcommands branch from cdb97cc to 1f30fd3 Compare June 13, 2024 15:23
Copy link

🤖 Pull Request Artifacts (#9502398798) 🎉

@pallabpain pallabpain force-pushed the add/hwil-subcommands branch from 1f30fd3 to 08a0b15 Compare June 13, 2024 15:58
Copy link

🤖 Pull Request Artifacts (#9502895514) 🎉

This commit introduces the command to manage hardware-in-loop devices.

Usage: rio hwil [OPTIONS] COMMAND [ARGS]...

  Manage Hardware-in-the-Loop (HWIL) devices

Options:
  --help  Show this message and exit.

Commands:
  create   Create a new hardware-in-the-loop device.
  delete   Delete one or more devices
  execute  Execute
  inspect  Inspect the hardware-in-the-loop device.
  list     Lists hardware-in-loop devices.
  login    Log in to HWIL.
  ssh      SSH into the hardware-in-the-loop device.
@pallabpain pallabpain force-pushed the add/hwil-subcommands branch from 08a0b15 to 621985d Compare June 13, 2024 16:00
Copy link

🤖 Pull Request Artifacts (#9502928594) 🎉

Copy link

🤖 Pull Request Artifacts (#9512203016) 🎉

@pallabpain pallabpain merged commit 3e24b0b into devel Jun 14, 2024
6 checks passed
rr-github-ci-user pushed a commit that referenced this pull request Jul 4, 2024
# [7.6.0](v7.5.0...v7.6.0) (2024-07-04)

### Bug Fixes

* **device:** sets device labels correctly ([#329](#329)) ([a3ac73d](a3ac73d))
* **device:** sets highperf label on virtual device ([#328](#328)) ([1eb7906](1eb7906))
* **project:** updates subnet when vpn is already enabled ([#324](#324)) ([e8d553b](e8d553b))

### Features

* **configtree:** add export command ([6f236ae](6f236ae))
* **configtree:** add support for diff ([7df605e](7df605e))
* **configtree:** add support for merge ([a1d273f](a1d273f))
* **configtree:** add support for milestone ([6ada3f7](6ada3f7))
* **device:** supports onboarding hwil devices via device manifest ([#323](#323)) ([7c257f1](7c257f1))
* **hwil:** implements hwil command ([#319](#319)) ([3e24b0b](3e24b0b))
@rr-github-ci-user
Copy link
Collaborator

🎉 This PR is included in version 7.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pallabpain pallabpain deleted the add/hwil-subcommands branch October 14, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature A new feature addition to the CLI released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants