Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bulk actions breaking change #535

Merged
merged 2 commits into from
Nov 2, 2021
Merged

fix bulk actions breaking change #535

merged 2 commits into from
Nov 2, 2021

Conversation

fabio-ivona
Copy link
Contributor

@fabio-ivona fabio-ivona commented Oct 28, 2021

@rappasoft this PR will fix issues in project with custom views after adding the bulkActions() function support see (#467 and #517)

custom views that use old $bulkActions notation instead of $this->bulkActions (needed for computed property) are breaking (I think this is why we ended adding and removing $bulkActions property multiple times)

for explanation of the issue, see #533

the fix is to pass a $bulkActions attribute to the rendered view in order to allow the old notation to work

this can be eventually removed in a future major version

@fabio-ivona fabio-ivona mentioned this pull request Oct 28, 2021
8 tasks
@aeq-dev
Copy link

aeq-dev commented Oct 30, 2021

Hello there,
The bulk action drop-down doesn't work if I select some records and do some filters.
Bootstrap 5

@fabio-ivona
Copy link
Contributor Author

@aeq-dev have you customized any view?

@aeq-dev
Copy link

aeq-dev commented Oct 30, 2021

@fabio-ivona never mind, sorry I did update for package but didn't republish views.
Thanks

@fabio-ivona
Copy link
Contributor Author

There's no need to publish views if you don't have to change them, it is discouraged in the docs, also 😉

@aeq-dev
Copy link

aeq-dev commented Oct 31, 2021

Yes I know, I did some changes in row, filters and bulk action :)

@rappasoft rappasoft mentioned this pull request Nov 2, 2021
@rappasoft rappasoft merged commit ebf4f48 into rappasoft:master Nov 2, 2021
@fabio-ivona fabio-ivona deleted the fix-bulkActions-breaking-change branch November 2, 2021 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants