-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bulk select with search and add typed property to selected #439
Fix bulk select with search and add typed property to selected #439
Conversation
This is a small change but I don't know what it's going to do to the rest of the functionality. There is extra functionality in the rowsQuery method that is now being ignored. |
There shouldn't be any problem because it takes query passed down by user without any other parameters, filters etc. and affects only selected rows based on array of selected ids. rowsQuery is still used but not for bulk select action. Also I tested it a little and didn't notice any problem. |
How do I set it up to get the error that this fixes? |
Select 1 column and then search for some other column to select it so the previous one is not present in table. Then if you want to run some action you only get searched result because it clones query with search parameters. Fix is just simply taking base query provided by user without any changes. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Having a hard time reproducing this issue but if it fixes #412 I want to figure it out. |
Steps to Reproduce:
Result: Only the column that is being searched is on the bulk.select.selectedRowsQuery.selectedKeys.mov |
#412