Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bulk select with search and add typed property to selected #439

Merged
merged 3 commits into from
Oct 13, 2021

Conversation

Majkie
Copy link
Contributor

@Majkie Majkie commented Aug 18, 2021

@rappasoft
Copy link
Owner

This is a small change but I don't know what it's going to do to the rest of the functionality. There is extra functionality in the rowsQuery method that is now being ignored.

@Majkie
Copy link
Contributor Author

Majkie commented Aug 24, 2021

There shouldn't be any problem because it takes query passed down by user without any other parameters, filters etc. and affects only selected rows based on array of selected ids. rowsQuery is still used but not for bulk select action. Also I tested it a little and didn't notice any problem.

@rappasoft
Copy link
Owner

How do I set it up to get the error that this fixes?

@Majkie
Copy link
Contributor Author

Majkie commented Aug 25, 2021

Select 1 column and then search for some other column to select it so the previous one is not present in table. Then if you want to run some action you only get searched result because it clones query with search parameters. Fix is just simply taking base query provided by user without any changes.

@stale
Copy link

stale bot commented Sep 25, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Sep 25, 2021
@rappasoft
Copy link
Owner

Having a hard time reproducing this issue but if it fixes #412 I want to figure it out.

@stale stale bot removed the wontfix This will not be worked on label Sep 26, 2021
@KevinYobeth
Copy link

Steps to Reproduce:

  1. Select 1 column
  2. Search for any other entries and select 1 of them
  3. Run bulk action

Result: Only the column that is being searched is on the selectedRowsQuery and selectedKeys
Expected: Both the searched and previously selected column should be on selectedRowsQuery and selectedKeys

bulk.select.selectedRowsQuery.selectedKeys.mov

@rappasoft rappasoft added the Awaiting Next Release Currently merged into development awaiting a release to master label Oct 13, 2021
@rappasoft rappasoft mentioned this pull request Oct 13, 2021
@rappasoft rappasoft merged commit 7512de5 into rappasoft:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Next Release Currently merged into development awaiting a release to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants