Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.7.0 #287

Merged
merged 22 commits into from
May 19, 2021
Merged

v1.7.0 #287

merged 22 commits into from
May 19, 2021

Conversation

bdelamatre and others added 22 commits May 14, 2021 08:36
Took 13 minutes
1) Eliminated the if block that wrapped the whole view because the view script should display its contents regardless of whether pagination is enabled or not. This is because it's also responsible for displaying the result count.

2) Fixed the links() logic to check $showPagination and not $showPerPage. Show Per Page's effect should be isolated to the per page select element, not whether the pagination links should be displayed.
Took 5 minutes
Took 12 minutes
Took 12 seconds
@rappasoft rappasoft merged commit 3482038 into master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants