-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FixSetDefaultPerPage #2067
Merged
lrljoe
merged 6 commits into
rappasoft:development
from
LowerRockLabs:FixSetDefaultPerPage
Nov 17, 2024
Merged
FixSetDefaultPerPage #2067
lrljoe
merged 6 commits into
rappasoft:development
from
LowerRockLabs:FixSetDefaultPerPage
Nov 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #2067 +/- ##
=================================================
+ Coverage 88.04% 88.05% +0.01%
- Complexity 1934 1937 +3
=================================================
Files 184 184
Lines 4426 4430 +4
=================================================
+ Hits 3897 3901 +4
Misses 529 529 ☔ View full report in Codecov by Sentry. |
lrljoe
added a commit
that referenced
this pull request
Nov 18, 2024
Co-authored-by: lrljoe <[email protected]> * Remove Waiting For Tests * Use CODECOV_TOKEN * Fix styling * Update phpdoc for boot (#2055) * Update phpdoc for boot * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Add test for No Columns defined - throws correct Exception (#2057) * Add test for No Columns * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Add Simple updatedSearch tests (#2058) * Add Simple updatedSearch tests * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Add test for FilterApplied Event being dispatched (#2059) * Add test for FilterApplied being dispatched * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Add updatedSelectedColumns test for Event (#2060) * Add test for ColumnsSelected Event dispatch * Apply Separate Tests --------- Co-authored-by: lrljoe <[email protected]> * Adjustment for DateRangeFilter (#2064) * Adjust SessionStorageHelpersTest (#2065) * FixSetDefaultPerPage (#2067) * FixSetDefaultPerPage * Update getDefaultPerPage to respect getPerPageAccepted * Fix missing ) * Fix styling * Add test fix * Add final tests --------- Co-authored-by: lrljoe <[email protected]> * Fix BooleanColumn unexpected truthy behaviour (#2066) * Fix BooleanColumn unexpected truthy behaviour * Support previous iteration * Update ChangeLog ---------
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tweak ensures that the setDefaultPerPage(x) is respected, if perPage has not already been set.
All Submissions:
New Feature Submissions:
Changes to Core Features: