Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the reorderFunction and tableWrapper for users with published views #1848

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Aug 15, 2024

This is a change that restores the original reorderFunction and tableWrapper to the package JS files, to mitigate a breaking change from people with published views..

Longer term - these will be deprecated and removed!

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.35%. Comparing base (40485a0) to head (592d726).
Report is 60 commits behind head on development.

Additional details and impacted files
@@                Coverage Diff                @@
##             development    #1848      +/-   ##
=================================================
+ Coverage          87.14%   88.35%   +1.21%     
- Complexity          1495     1649     +154     
=================================================
  Files                139      150      +11     
  Lines               3484     3840     +356     
=================================================
+ Hits                3036     3393     +357     
+ Misses               448      447       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit 25a985c into rappasoft:development Aug 15, 2024
9 checks passed
lrljoe added a commit that referenced this pull request Aug 16, 2024
## [v3.4.6] - 2024-08-16
### New Features
- Column Features - deselectedIf/selectedIf by @lrljoe in #1846
- Add setTrimSearchStringEnabled/setTrimSearchStringDisabled by @lrljoe in #1843

### Bug Fixes
- Restore the original JS methods for users with published views by @lrljoe in #1848

### Tweaks
- Remove Component from Column, move getRows into ComputedProperty by @lrljoe in #1838
- Clean up filter generic data by @lrljoe in #1837
- Clean up of Views, Properties by @lrljoe in #1850
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant