-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidying Filters - Migrating Carbon usage into Trait, Adding Lifecycle Hooks #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ter to use Core Trait
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #1798 +/- ##
=================================================
+ Coverage 87.14% 87.34% +0.20%
- Complexity 1495 1518 +23
=================================================
Files 139 141 +2
Lines 3484 3548 +64
=================================================
+ Hits 3036 3099 +63
- Misses 448 449 +1 ☔ View full report in Codecov by Sentry. |
lrljoe
added a commit
that referenced
this pull request
Jul 27, 2024
* Add SetFilterDefaultValue to DateRange Filter (#1796) --------- Co-authored-by: lrljoe <[email protected]> * Add Localised Pills for DateRangeFilter --------- Co-authored-by: lrljoe <[email protected]> * Tidying Filters - Migrating Carbon usage into Trait, Adding Lifecycle Hooks (#1798) * Tweaks to handle dates centrally * Add localisation for DateFilter, DateTimeFilter, migrate DateRangeFilter to use Core Trait * Add Filter Lifecycle Hooks * Add Search Lifecycle Hook * Update DateFilter, DateTimeFilter validate returns * Update DateRangeFilterTest * Add Pills Locale Tests to DateTests * Remove superfluous method --------- Co-authored-by: lrljoe <[email protected]> * Update ChangeLog * Update docs for setPillsLocale (#1800) --------- Co-authored-by: lrljoe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes:
Filters
Utilise a Core Trait for processing Dates (used in DateFilter, DateTimeFilter, DateRangeFilter)
Add the following lifecycle hooks:
searchUpdated
This is called whenever the search is updated, and is passed the value that has been searched for
filterApplying
This is called whenever a Filter is applying
filterReset
This is called whenever a Filter is reset
filterSet
This is called whenever a Filter is set
filterUpdated
This is called whenever a Filter is updated/used
filterRemoved
This is called whenever a Filter is removed from the table
All Submissions:
New Feature Submissions:
Changes to Core Features: