Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NumberRangeFixes - Prepopulated Positions #1774

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Jul 16, 2024

This fix addresses the pre-population of NumberRangeFilter values, and the resultant initial display of the filter

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (development@d77545d). Learn more about missing BASE report.

Additional details and impacted files
@@              Coverage Diff               @@
##             development    #1774   +/-   ##
==============================================
  Coverage               ?   87.10%           
  Complexity             ?     1482           
==============================================
  Files                  ?      136           
  Lines                  ?     3450           
  Branches               ?        0           
==============================================
  Hits                   ?     3005           
  Misses                 ?      445           
  Partials               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit 1717da5 into rappasoft:development Jul 16, 2024
9 checks passed
lrljoe added a commit that referenced this pull request Jul 16, 2024
### Bug Fixes
- Fix NumberRangeFilter initial state when loaded by querystring by @lrljoe in #1774
- Fix SnakeCase issue with snake-cased relations for AggregateColumn types (AvgColumn, CountColumn, SumColumn) by @lrljoe in #1777

### New Features
- Set a Prefix for NumberRangeFilter by @RenoLooijmans in #1773
- Add Separator customisation for Array Filters for FilterPills by @lrljoe in #1772
- Add bulk actions button/dropdown customisations by @lrljoe in #1771

Co-authored-by: lrljoe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant