Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add User prompt for missing inputs #1681

Merged
merged 29 commits into from
Apr 30, 2024

Conversation

achyutkneupane
Copy link
Contributor

This provides option in console to prompt for missing input.

Screenshots:

For Model:

image
image
image

For Model with modelpath

image

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

lrljoe and others added 26 commits November 3, 2023 16:02
Add Initial Lifecycle Hooks - Configuring/Configured by @lrljoe in v3 - Initial Lifecycle Hooks - Configuring/Configured rappasoft#1520
Add "HasAllTraits" for Maintainability by @lrljoe in v3 - Splitting Codebase - ConfigurableAreas, CollapsingColumns and TableAttributes rappasoft#1514
Rename row-contents blades for clarity by @lrljoe in V3 Rename row-contents blades rappasoft#1519
Add missing tests for DateFilter and DateTimeFilter by @lrljoe in V3 Adds missing tests for DateTimeFilter and DateFilter rappasoft#1527
- Add additional Lifecycle Hook by @lrljoe in rappasoft#1534
  - SettingColumns/ColumnsSet
- Migrate methods for pre-render out of render by @lrljoe in rappasoft#1534
- Update tests to reflect hooks by @lrljoe in rappasoft#1534
- Update tests to add invalid string tests for dates by @lrljoe in rappasoft#1534
- Remove maps and minimise functions from FrontendAssets by @lrljoe in rappasoft#1534
Develop to Master - Workflows Only
## [v3.1.4] - 2023-12-04
### New Features
- Add capability to hide Column Label by @lrljoe in rappasoft#1512
- Add capability to set a custom script path for the scripts/styles by @lrljoe in rappasoft#1557
- Added rowsRetrieved Lifecycle Hook, expanded documentation for Lifecycle Hooks

### Bug Fixes
- Added missing tailwind background colour class for when hovering over the clear button in dark mode by @slakbal in rappasoft#1553
- Fixed extraneous space in config.php by @viliusvsx in in rappasoft#1577
- Changed table default vertical overflow to auto by @dmyers in rappasoft#1573
- Fix footer rendering issue with extra td displayed depending on bulk action statuses

### Tweaks
- Create additional Exception Classes (NoColumnsException, NoSearchableColumnsException, NoSortableColumnsException)
- Revert previous splitting of JS Files
- Add capability to customise Bulk Actions Styling with tests by @lrljoe in rappasoft#1564
  - TH Classes
  - TH Checkbox Classes
  - TD Classes
  - TD Checkbox Classes
@achyutkneupane achyutkneupane changed the base branch from master to develop March 4, 2024 19:07
@achyutkneupane achyutkneupane changed the base branch from develop to master March 4, 2024 19:08
@achyutkneupane
Copy link
Contributor Author

@lrljoe Can you review this?

@lrljoe lrljoe changed the base branch from master to develop March 7, 2024 08:52
@lrljoe
Copy link
Collaborator

lrljoe commented Mar 7, 2024

Looks okay to me. Away for a bit but @rappasoft may be able to merge this in and do a release

Copy link

stale bot commented Apr 11, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 11, 2024
@achyutkneupane
Copy link
Contributor Author

@lrljoe @rappasoft
Any update on this?

@stale stale bot removed the wontfix This will not be worked on label Apr 16, 2024
@lrljoe
Copy link
Collaborator

lrljoe commented Apr 29, 2024

Apologies, been a bit busy of late! Will look to get this reviewed and merged in this week.

@lrljoe lrljoe merged commit 2068b86 into rappasoft:develop Apr 30, 2024
7 checks passed
@achyutkneupane achyutkneupane deleted the artisan-prompt branch April 30, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants