-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Toggle Pagination Details Display #1618
Merged
lrljoe
merged 11 commits into
rappasoft:develop
from
LowerRockLabs:TogglePaginationDetails
Dec 29, 2023
Merged
Enable Toggle Pagination Details Display #1618
lrljoe
merged 11 commits into
rappasoft:develop
from
LowerRockLabs:TogglePaginationDetails
Dec 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1618 +/- ##
=============================================
+ Coverage 88.56% 88.67% +0.11%
- Complexity 1346 1354 +8
=============================================
Files 106 106
Lines 3167 3189 +22
=============================================
+ Hits 2805 2828 +23
+ Misses 362 361 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two Pagination Related Changes
Conditional Display/Hiding of Details
This enables configurable display/hiding of the pagination details, i.e. "Showing x to y of z results"
This remains displayed by default, and pagination buttons are not affected
queryString perPage
To ensure persistence of the perPage, it is now added to the queryString with a unique key.
All Submissions:
New Feature Submissions:
Changes to Core Features: