Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Toggle Pagination Details Display #1618

Merged
merged 11 commits into from
Dec 29, 2023

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Dec 29, 2023

Two Pagination Related Changes

Conditional Display/Hiding of Details

This enables configurable display/hiding of the pagination details, i.e. "Showing x to y of z results"
pagination details example

This remains displayed by default, and pagination buttons are not affected

queryString perPage

To ensure persistence of the perPage, it is now added to the queryString with a unique key.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@lrljoe lrljoe marked this pull request as draft December 29, 2023 20:34
Copy link

codecov bot commented Dec 29, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (082f5c7) 88.56% compared to head (67e899c) 88.67%.

❗ Current head 67e899c differs from pull request most recent head ec64c15. Consider uploading reports for the commit ec64c15 to get more accurate results

Files Patch % Lines
src/Traits/WithPagination.php 60.00% 6 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1618      +/-   ##
=============================================
+ Coverage      88.56%   88.67%   +0.11%     
- Complexity      1346     1354       +8     
=============================================
  Files            106      106              
  Lines           3167     3189      +22     
=============================================
+ Hits            2805     2828      +23     
+ Misses           362      361       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe marked this pull request as ready for review December 29, 2023 22:10
@lrljoe lrljoe merged commit a0d8411 into rappasoft:develop Dec 29, 2023
@lrljoe lrljoe mentioned this pull request Dec 29, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant