Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DateColumn #1589

Merged
merged 12 commits into from
Dec 9, 2023
Merged

Add DateColumn #1589

merged 12 commits into from
Dec 9, 2023

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Dec 9, 2023

This adds a new DateColumn, which can receive either DateTime objects, or strings

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Dec 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (69a64c3) 89.08% compared to head (868bef0) 89.17%.

❗ Current head 868bef0 differs from pull request most recent head d0c8dd8. Consider uploading reports for the commit d0c8dd8 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1589      +/-   ##
=============================================
+ Coverage      89.08%   89.17%   +0.08%     
- Complexity      1307     1317      +10     
=============================================
  Files             99      102       +3     
  Lines           3078     3103      +25     
=============================================
+ Hits            2742     2767      +25     
  Misses           336      336              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit dc97763 into rappasoft:develop Dec 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant