Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V3 - Develop to Master - Toolbar splitting #1461

Merged
merged 7 commits into from
Oct 27, 2023
Merged

V3 - Develop to Master - Toolbar splitting #1461

merged 7 commits into from
Oct 27, 2023

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Oct 27, 2023

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

lrljoe and others added 3 commits October 25, 2023 23:15
* Fix for setFilter

* Update return types

---------

Co-authored-by: lrljoe <[email protected]>
* Initial Commit - Full Split of Toolbar

* Remove Confirms Code

* Fix superfluous endif

* Combining Blades - Stage 1

* More Merging

* Bulk Actions - Icon Adjustment

* Further clean up of toolbar - filter button

* Stripping Toolbar Theme Distinctions

* Adjust childElementOpen to respect hierachy

* To remove files

* Merge Column-Select into Single Blade

* Clean Up Blades
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #1461 (5a2c14e) into v3-master (cbbb283) will decrease coverage by 0.09%.
Report is 5 commits behind head on v3-master.
The diff coverage is 88.33%.

@@               Coverage Diff               @@
##             v3-master    #1461      +/-   ##
===============================================
- Coverage        88.11%   88.03%   -0.09%     
- Complexity        1222     1239      +17     
===============================================
  Files               85       88       +3     
  Lines             2971     3001      +30     
===============================================
+ Hits              2618     2642      +24     
- Misses             353      359       +6     
Files Coverage Δ
src/DataTableComponent.php 96.66% <ø> (ø)
src/Traits/ComponentUtilities.php 90.00% <ø> (ø)
...rc/Traits/Configuration/ComponentConfiguration.php 100.00% <ø> (ø)
.../Traits/Configuration/QueryStringConfiguration.php 100.00% <100.00%> (ø)
src/Traits/Helpers/ComponentHelpers.php 99.05% <ø> (-0.07%) ⬇️
src/Traits/WithColumnSelect.php 71.11% <83.33%> (+1.88%) ⬆️
src/Traits/WithFilters.php 88.88% <83.33%> (-2.78%) ⬇️
src/Traits/WithQueryString.php 83.33% <83.33%> (ø)
src/Traits/WithSearch.php 94.11% <83.33%> (-5.89%) ⬇️
src/Traits/WithSorting.php 84.78% <83.33%> (-0.22%) ⬇️
... and 1 more

lrljoe and others added 4 commits October 27, 2023 22:39
* Initial migration of queryString to Traits

* Lock $queryStringStatus

* Return empty arrays for Traits

* Add WithQueryString Trait

* Add Config/Helper Traits to WithQueryString

* Add default queryStringStatus

---------

Co-authored-by: lrljoe <[email protected]>
@lrljoe lrljoe merged commit cf20177 into v3-master Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant