v2.12 #1145
Merged
v2.12 #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding new methods & test Adding documentation
Update run-tests.yml Fixing typo in class name Update composer.json Update run-tests.yml
Workflow (run-tests) - Use of ParaTest, Composer Caching, Fix Stability Matrix Clash
…ility improve active page visibility
Additional AlpineJS Variable for Toolbar Blade - childElementOpen
Core - New Functionality - Add Custom Column Slug option
Update es.json
Added eagerloading so anyone can load any type of relationship
Adding row language option Remove PHPUnit 10 Add coverage cache Restore usage of pcov Update for PHPUnit 10 WF Updates Move Problem Matchers Merge Push Tests Test WF Merge WF Restoring PHPUnit Revert WF & Composer Changes Adding row to remaining languages Adding row to remaining languages
Alphabetising and Adding Missing Translations
Run-Tests now runs in the following order - First run PHP CS Fixer (on PUSH ONLY) - Next run the matrix This removes the potential for CS Fixer to make changes to the codebase after tests have commenced.
Workflow Tweaks - Removing Separate CS-Fixer
Restoring CSFixer Badge Capability
Develop docs only
* Restrict AppliedFilters to only return non-empty At the moment, a filter will be considered "applied" if it has any value, including the default value. This causes the Pills to appear with a blank value. * Moving to withValues to make more sense * Initial Commit * Add variable to Filter.php * Filter LabelID (#32) * Amended to removing formatting adjustments Adding ID to Label Update toolbar.blade.php Adding new line at EOF * Update toolbar.blade.php Adding ID to Wrapper * Amended to removing formatting adjustments Adding ID to Label Adding ID to Wrapper Adding new line at EOF Update toolbar.blade.php Adding ID to Wrapper * Update toolbar.blade.php Adds IDs to Filter Labels Adds IDs to Filter Wrappers Restores removed EOF newline * Restoring New Line at EOF * Child open attribute (#35) * Adding childElementOpen attr for all toolbar items. * Adjusting Toolbar to remove errant formatting * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Set filter pill custom blade (#33) * Initial Commit * Add variable to Filter.php * Get applied filters only non empty (#34) * Restrict AppliedFilters to only return non-empty At the moment, a filter will be considered "applied" if it has any value, including the default value. This causes the Pills to appear with a blank value. * Moving to withValues to make more sense * Set filter row colspan (#36) * Adding Custom Slug option (#21) Adding new methods & test Adding documentation * Filter label (#22) * Amended to removing formatting adjustments Adding ID to Label Update toolbar.blade.php Adding new line at EOF * Update toolbar.blade.php Adding ID to Wrapper * Amended to removing formatting adjustments Adding ID to Label Adding ID to Wrapper Adding new line at EOF Update toolbar.blade.php Adding ID to Wrapper * Update toolbar.blade.php Adds IDs to Filter Labels Adds IDs to Filter Wrappers Restores removed EOF newline * Restoring New Line at EOF * Adding Filter Custom Pills blade option (#23) * Adding Filter Custom Pills blade option * Removing formatting changes * Get applied filters only non empty (#24) * Restrict AppliedFilters to only return non-empty At the moment, a filter will be considered "applied" if it has any value, including the default value. This causes the Pills to appear with a blank value. * Moving to withValues to make more sense * Child open attribute (#25) * Adding childElementOpen attr for all toolbar items. * Adjusting Toolbar to remove errant formatting * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Adding getAdditionalSelectRaws (#26) Using selectRaw rather than directly using DB Referencing DB directly rather than a use Fix styling Fixing test Restoring workflows Removing automated on-push Setting up configuration elements, documentation Adding parameterised capability * Update composer.json * Update run-tests.yml * Fix doc types (#27) * Update toolbar.blade.php * Update Filter.php * Update FilterHelpers.php * Fix styling * Update FilterConfiguration.php * Fix styling * Initial DocType Fixes * Fix styling * PHPDoc FIxes * Toolbar Blade Fixes for Pagination * Fix styling * Removing non-nullable return * Fixing DocType issues * Reverting minor tweaks due to PHPUnit failures * Removing PHPStan * Additional PHPDoc Fixes * Fixes for PHPDocTypes * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Update composer.json * Custom pill views (#29) * Adding Filter Custom Pills blade option * Removing formatting changes * Initial Commit * Fix styling * Fix for errant line end * Fix styling * Minor Tweaks * Remove ParaTest for this branch * Restore Run-tests for this branch * Remove CustomFilterPil * Reverting Numerous Changes to Doctypes - Branches * Fix Mistaken Branch merge * More remediation to remove branch merges * Fix styling * More removals of branch merge * Adding SlideDownRow and SlideDownColspan Tests * Fix styling * Restoring original workflow * Restoring CS FIxer --------- Co-authored-by: lrljoe <[email protected]> * Adding test for get/set custom pills * Fix styling * Update Test * Initial Commit add filterPosition to header/footer * Fix styling * Move Labels to Blades & CustomFilterLabels * Move Labels to Blades & CustomFilterLabels * Fix styling * Add swapping for slidedown/popover for BS4/5 * Fix styling * Custom filter labels (#39) * Move Labels to Blades & CustomFilterLabels * Move Labels to Blades & CustomFilterLabels * Fix styling * Add swapping for slidedown/popover for BS4/5 * Fix styling --------- Co-authored-by: lrljoe <[email protected]> * Fix styling * Extra Tests * Fix styling * Removing duplicate method * Fix styling * Test Fixes - TypeHinting * Remove Protected Property * Property Fixes * Row/Colspan - move to string|int * Doc Updates --------- Co-authored-by: lrljoe <[email protected]>
* ChangeLog Updates * Adding additional changes
* Trait Configuration/Helpers * Fix styling * PHPStan * Remove dynamic property dataTableFingerprint * Fix styling * DocType Fixes * Merge branch 'docTypeFixes' * TypeHint Fixes * Fix styling * Fix int/string refreshTime * PHPStan Fixes * Broken Footer/Header Methods * Update gitattributes * PHPStan-L3-Minimum --------- Co-authored-by: lrljoe <[email protected]>
* Pagination Updates * Updating ChangeLog --------- Co-authored-by: lrljoe <[email protected]>
* Additional Tests * DB Switching * Workflow Tweaks * Fix styling --------- Co-authored-by: lrljoe <[email protected]>
|
Just doing some checks on my end to see if I can figure out what's causing that test to fail, as it was all passing on my runners here. |
* Fix styling * Change Cache Name - Test * Change Fail Fast to False * Revert CS Fixer * Restore Collision Versioning * Restore test adjustments * Fix styling * Revert errant change to ColumnHelpers Test --------- Co-authored-by: lrljoe <[email protected]>
|
Believe this is due to caching issues where the push & pull jobs are running simultaneously, just running some final checks on my end, then should have a fix. |
* Fix styling * Change Cache Name - Test * Change Fail Fast to False * Revert CS Fixer * Restore Collision Versioning * Restore test adjustments * Fix styling * Revert errant change to ColumnHelpers Test * Add Cache Clearing & Cache to Array * Remove Artisan reference * Disable View Cache for Tests * Split Push/Pull Jobs --------- Co-authored-by: lrljoe <[email protected]>
* Test Fixes * Fix styling\n\nskip-checks:true * Clean up CSFixer --------- Co-authored-by: lrljoe <[email protected]>
|
@rappasoft - So I've managed to get the errored tests to resolve by setting a rand(0,100) append to the View Cache path. I'll look at a better approach for the next release. It was caching Views via TestBench, and because of the matrices, this was causing it to return the same view for different tests sporadically. |
lrljoe
approved these changes
Apr 9, 2023
There was a problem hiding this comment.
I am comfortable with these changes, please @rappasoft do double check my sanity!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
AlpineJS Variable for Toolbar Dropdowns to force the dropdown to remain open - childElementOpen - Additional AlpineJS Variable for Toolbar Blade - childElementOpen #1076
Added Custom Column Slug method setCustomSlug('') allowing Columns to use non-roman characters in the Column Title - Core - New Functionality - Add Custom Column Slug option #1088
Eager loading so anyone can load any type of relationship - Added eagerloading so anyone can load any type of relationship #943
Improved visibility of active page in pagination - improve active page visibility #1096
Pagination methods
Filter Changes - Filters combined final #1129
Changed
Filters
Workflow Changes
Testing