Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk Actions Simple Pagination fix & typo in toolbar.blade.php #1015

Merged
merged 2 commits into from
Jan 17, 2023

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Jan 12, 2023

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Two blade fixes in this pull request:

  1. Presently, the Total Count will always try to render. This fix prevents it from doing so when in SimplePagination made. When in SimplePagination, the TotalCount is not avaialble, resulting in an exception being thrown.
    The code changes simply exclude the display of the "total" to ensure that the exception isn't thrown.

  2. There was a typo reported within toolbar.blade.php whereby toolbar-right-end is referenced as toolbar-righ-end for parameters, causing users to be unable to set thsese correctly. Typo fixed.

@lrljoe lrljoe mentioned this pull request Jan 12, 2023
@lrljoe lrljoe changed the title Fix for simple pagination bulk actions Fix for bulk actions when using Simple Pagination, and typo in toolbar blade Jan 12, 2023
@lrljoe lrljoe changed the title Fix for bulk actions when using Simple Pagination, and typo in toolbar blade Bulk Actions Simple Pagination fix & typo in toolbar.blade.php Jan 12, 2023
@rappasoft rappasoft added the Awaiting Next Release Currently merged into development awaiting a release to master label Jan 17, 2023
@rappasoft rappasoft mentioned this pull request Jan 17, 2023
@rappasoft rappasoft merged commit f5ca949 into rappasoft:master Jan 17, 2023
@lrljoe lrljoe deleted the BulkActionsCount branch April 17, 2023 02:19
@lrljoe lrljoe restored the BulkActionsCount branch April 17, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Next Release Currently merged into development awaiting a release to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants