Fix dependencies on librmm and libraft. #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
commented
Nov 20, 2023
| @@ -67,13 +67,15 @@ dependencies: | |||
| - output_types: conda | |||
| packages: | |||
| - c-compiler | |||
| - cmake>=3.23.1,!=3.25.0 | |||
| - cmake>=3.26.4 | |||
There was a problem hiding this comment.
I updated this cmake pinning to match the rest of RAPIDS -- and the pinnings in meta.yaml.
raydouglass
approved these changes
Nov 20, 2023
raydouglass
added
improvement
|
/rerun tests |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package currently has runtime dependencies on librmm and libraft-headers. However, these packages are header-only, so it's only sensible to require them at build time. This PR removes librmm and libraft-headers from the runtime dependencies of libwholegraph.
This PR is needed to fix the conda environments in unified devcontainers.