Fix ucxx constraints
#195
Merged
Fix ucxx constraints
#195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the CUDA compiler was only used by `ucxx` for CUDA 12. This makes sure it is used for CUDA 11 too to be consistent.
Having the CUDA compiler as a build dependency in `ucxx` means that some requirements are added to `ucxx` at runtime (like a `cuda-version` minimum). However we know we can have a more lax constraint on these dependencies at runtime. So ignore `run_exports` that the CUDA compiler would add.
jakirkham
added
bug
bdice
approved these changes
Feb 21, 2024
raydouglass
approved these changes
Feb 21, 2024
|
/merge |
|
Thanks all! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ucxx's CUDA compiler dependency added acuda-versionconstraint at runtime that meant packages could only be installed with the same CUDA versionucxxwas built with or newer. As a result CUDA 12.2 builds ofucxxrequired that CUDA 12.2+ would be used at runtimeHowever as we use CUDA Compatibility in RAPIDS, we know that even if we built with CUDA 12.2, we can still use packages for other CUDA 12.x
This was largely handled for other dependencies as part of PR ( #161 ). However this wasn't handled for
ucxx, which was likely in part as it was handling the CUDA compiler dependency differently from the other packages here. More history aboutucxx's CUDA compiler dependency in PR: #108This change aligns how CUDA compiler is handled across packages to make this more consistent. Also it ignores the CUDA compiler constraints added at runtime. In all cases the packages handle this themselves by requiring
cuda-version(properly constrained) and when CUDA 11 is concerned they addcudatoolkitThus this change should fix CI issues that were seen due to this overly constrained
cuda-versionby relaxing that constraint