-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide ./build.sh flag to control CUDA async malloc support #901
Merged
rapids-bot
merged 5 commits into
rapidsai:branch-21.12
from
robertmaynard:option_to_disable_async_support
Nov 3, 2021
Merged
Provide ./build.sh flag to control CUDA async malloc support #901
rapids-bot
merged 5 commits into
rapidsai:branch-21.12
from
robertmaynard:option_to_disable_async_support
Nov 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows rmm to be built with CUDA 11.2 but removes the runtime requirement of CUDA 11.2+, allowing for execution with older CUDA 11.X runtimes.
robertmaynard
added
3 - Ready for review
Ready for review by team
CMake
conda
non-breaking
Non-breaking change
improvement
Improvement / enhancement to an existing function
labels
Nov 1, 2021
github-actions
bot
added
cpp
Pertains to C++ code
Python
Related to RMM Python API
and removed
conda
labels
Nov 1, 2021
galipremsagar
approved these changes
Nov 1, 2021
rongou
reviewed
Nov 1, 2021
harrism
requested changes
Nov 1, 2021
rongou
approved these changes
Nov 2, 2021
harrism
requested changes
Nov 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed one?
codereport
approved these changes
Nov 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .hpp looks fine
harrism
approved these changes
Nov 3, 2021
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for review
Ready for review by team
CMake
cpp
Pertains to C++ code
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
Python
Related to RMM Python API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows rmm to be built with CUDA 11.2 but removes the runtime requirement of CUDA 11.2+, allowing for execution
with older CUDA 11.X runtimes.