Remove leading zeros in version_config.hpp #793
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we switched to CalVer, the version strings contain leading zeros, e.g.
21.08.00
. This leads to the generated headerversion_config.hpp
to containin which
08
is an invalid octal literal. See the resulting CI failure at https://gpuci.gpuopenanalytics.com/job/rapidsai/job/conda/job/xgboost/job/xgboost-conda-build/229/CUDA=11.0,PYTHON=3.7/console. The generated header is used by XGBoost.Fix: Remove the leading zeros in the C++ constants so that we'd get