Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cross-link to cuda-python object #1699

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Update cross-link to cuda-python object #1699

merged 2 commits into from
Oct 9, 2024

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Oct 9, 2024

Description

NVIDIA/cuda-python#137 reorganised the low-level binding structure which broke our cross-linking, update to the new name to fix.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@wence- wence- requested a review from a team as a code owner October 9, 2024 08:30
@github-actions github-actions bot added the Python Related to RMM Python API label Oct 9, 2024
@wence- wence- added doc Documentation non-breaking Non-breaking change labels Oct 9, 2024
@Matt711
Copy link
Contributor

Matt711 commented Oct 9, 2024

Example of the failure: https://github.com/rapidsai/rmm/actions/runs/11256211990/job/31298169643#step:9:1283

@wence-
Copy link
Contributor Author

wence- commented Oct 9, 2024

/merge

@rapids-bot rapids-bot bot merged commit 4e519bb into rapidsai:branch-24.12 Oct 9, 2024
55 checks passed
@wence- wence- deleted the wence/fix/1698 branch October 9, 2024 17:09
@harrism
Copy link
Member

harrism commented Oct 9, 2024

Thanks for fixing @wence- !

@jakirkham
Copy link
Member

cc @leofang (for vis)

@leofang
Copy link
Member

leofang commented Oct 10, 2024

cc @leofang (for vis)

Thanks, see #1698 (comment) / NVIDIA/cuda-python#140.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Matt711 Matt711 Matt711 approved these changes

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
doc Documentation non-breaking Non-breaking change Python Related to RMM Python API
Projects
RMM Project Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Doc build failures due to cuda-python namespace rewrite
6 participants
@wence- @Matt711 @harrism @jakirkham @leofang @bdice