Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude 'gcovr' from list of development pip packages #1688

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

jameslamb
Copy link
Member

Description

This project currently lists gcovr (https://pypi.org/project/gcovr/) as a pip dependency for development. I strongly suspect that that was unintentional... it doesn't look like it has any reliance on getting that package via pip (just conda, in the C++ test jobs and for local C++ development).

This proposes removing gcovr from the list of pip dependencies, so it won't get installed in the DLFW images or other places where rapids-make-pip-env from https://github.com/rapidsai/devcontainers is called.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Sep 27, 2024
@jameslamb jameslamb requested a review from a team as a code owner September 27, 2024 16:06
@jameslamb jameslamb changed the title WIP: exclude 'gcovr' from list of development pip packages exclude 'gcovr' from list of development pip packages Sep 27, 2024
@jameslamb
Copy link
Member Author

Thanks for joining and reviewing @vyasr !

@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit b514473 into rapidsai:branch-24.12 Sep 27, 2024
57 checks passed
@jameslamb jameslamb deleted the gcovr-conda-only branch September 27, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants