Update fmt (to 11.0.2) and spdlog (to 1.14.1). #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameslamb
added
non-breaking
7 tasks
bdice
reviewed
Sep 11, 2024
Co-authored-by: Bradley Dice <[email protected]>
bdice
reviewed
Sep 11, 2024
jameslamb
commented
Sep 19, 2024
| include("${rapids-cmake-dir}/export/find_package_root.cmake") | ||
| rapids_export_find_package_root(BUILD spdlog [=[${CMAKE_CURRENT_LIST_DIR}]=] | ||
| EXPORT_SET rmm-exports) | ||
| endif() |
There was a problem hiding this comment.
Context for these get_spdlog.cmake changes: rapidsai/rapids-cmake#387 (comment)
jameslamb
commented
Sep 19, 2024
jameslamb
changed the title
jameslamb
requested review from
msarahan,
bdice and
KyleFromNVIDIA
and removed request for
msarahan
bdice
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to:
fmtandspdlogacross RAPIDS build-planning#56Replaces #1544
Now that most of
conda-forgehas been updated tofmt >=11.0.1,<12andspdlog>=1.14.1,<1.15(rapidsai/build-planning#56 (comment)), we're attempting to upgrade RAPIDS to similar versions of those libraries.This impoves the likelihood that RAPIDS will be installable alongside newer versions of its dependencies and complementary packages on conda-forge.
Notes for Reviewers
This PR is testing changes made in rapidsai/rapids-cmake#689.
It shouldn't be merged until those
rapids-cmakechanges are merged and any testing-specific details have been removed.